3wordchant/capsul-flask
1
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

shell_scripts: Fix reporting of VM IP addresses #9

Merged
3wordchant merged 1 commits from mirsal/capsul-flask:ipv6 into master 2021-08-04 10:13:45 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
mirsal commented 2021-08-04 01:03:44 +00:00
Collaborator
Copy Link

The shell script which gets information from libvirt incorrectly
matches virsh output lines which contain VMs' public IPv4 addresses.
It doesn't work when there are multiple address families which breaks
reporting of IPv4 address when a VM also has an IPv6 address and virsh
happens to output that one first.

This commit changes it to explicitely match the first ipv4 address instead.

The shell script which gets information from libvirt incorrectly matches virsh output lines which contain VMs' public IPv4 addresses. It doesn't work when there are multiple address families which breaks reporting of IPv4 address when a VM also has an IPv6 address and virsh happens to output that one first. This commit changes it to explicitely match the first ipv4 address instead.
mirsal added 1 commit 2021-08-04 01:03:45 +00:00
shell_scripts: Fix reporting of VM IP addresses
Some checks failed
continuous-integration/drone/pr Build is failing
Details
d9f3e68278 
The shell script which gets informations from libvirt incorrectly
matches virsh output lines which contain VMs' public IPv4 addresses.
It doesn't work when there are multiple address families which breaks
reporting of IPv4 address when a VM also has an IPv6 address and virsh
happen to output that one first.

This commit changes it to explicitely match the first ipv4 address instead.
3wordchant merged commit 7b16606b16 into master 2021-08-04 10:13:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 3wordchant/capsul-flask#9
No description provided.
Delete Branch "mirsal/capsul-flask:ipv6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?