shell_scripts: Fix reporting of VM IP addresses #9

mirsal · 2021-08-04T01:03:44Z

mirsal commented

2021-08-04 01:03:44 +00:00

The shell script which gets information from libvirt incorrectly
matches virsh output lines which contain VMs' public IPv4 addresses.
It doesn't work when there are multiple address families which breaks
reporting of IPv4 address when a VM also has an IPv6 address and virsh
happens to output that one first.

This commit changes it to explicitely match the first ipv4 address instead.

The shell script which gets information from libvirt incorrectly matches virsh output lines which contain VMs' public IPv4 addresses. It doesn't work when there are multiple address families which breaks reporting of IPv4 address when a VM also has an IPv6 address and virsh happens to output that one first. This commit changes it to explicitely match the first ipv4 address instead.

mirsal added 1 commit 2021-08-04 01:03:45 +00:00

continuous-integration/drone/pr Build is failing Details

d9f3e68278 shell_scripts: Fix reporting of VM IP addresses

The shell script which gets informations from libvirt incorrectly
matches virsh output lines which contain VMs' public IPv4 addresses.
It doesn't work when there are multiple address families which breaks
reporting of IPv4 address when a VM also has an IPv6 address and virsh
happen to output that one first.

This commit changes it to explicitely match the first ipv4 address instead.

3wordchant merged commit 7b16606b16 into master

2021-08-04 10:13:45 +00:00

3wordchant referenced this issue from a commit

2021-08-04 10:13:45 +00:00

Merge pull request 'shell_scripts: Fix reporting of VM IP addresses' (#9) from mirsal/capsul-flask:ipv6 into master

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 3wordchant/capsul-flask#9