Fix argument passing for logs and run_args #12

New Issue

3wordchant · 2020-09-13T15:59:01Z

3wordchant commented

2020-09-13 15:59:01 +00:00

$ abra logs simplesaml --tail 20 -f --raw
unknown flag: --tail 20 -f --raw
$ abra run_args nextcloud "-u www-data" php /var/www/html/occ
unable to find user  www-data: no matching entries in passwd file

This was working prior to c7e5e3cc, I think we shouldn't quote $DOCKER_ARGS¬ or $LOGS_ARGS` because the shellcheck warning about "unexpected splitting" is actually what we want..

I will be more effective on this when I get round to installing shellcheck locally >.<

``` $ abra logs simplesaml --tail 20 -f --raw unknown flag: --tail 20 -f --raw $ abra run_args nextcloud "-u www-data" php /var/www/html/occ unable to find user www-data: no matching entries in passwd file ``` This was working prior to c7e5e3cc, I think we shouldn't quote `$DOCKER_ARGS¬ or `$LOGS_ARGS` because the shellcheck warning about "unexpected splitting" is actually what we want.. I will be more effective on this when I get round to installing `shellcheck` locally >.<

3wordchant added the

bug

label 2020-09-13 16:02:47 +00:00

decentral1se commented

2020-09-13 20:45:31 +00:00

Aha, I admit to not having a clue about bash. I see I can't just blindly apply the shellcheck hints and hope for the best without testing 🙈 lesson learned! I will assign this and fix-up when I get a chance to sit down to it.

Aha, I admit to not having a clue about bash. I see I can't just blindly apply the shellcheck hints and hope for the best without testing :see_no_evil: lesson learned! I will assign this and fix-up when I get a chance to sit down to it.

decentral1se self-assigned this 2020-09-13 20:45:36 +00:00

decentral1se commented

2020-09-13 21:37:33 +00:00

6fdb0d64af

https://git.autonomic.zone/autonomic-cooperative/abra/commit/6fdb0d64afd34d0cd8348327ce3a3ea360ffde5d

❤️ 1 🎉 1

3wordchant commented

2020-09-13 23:28:31 +00:00

Smashing, thank you! Sorry for being too lazy to work out the disable= incantation

Smashing, thank you! Sorry for being too lazy to work out the `disable=` incantation

3wordchant closed this issue

2020-09-14 00:24:21 +00:00