From 0656eee87a8385d48b3a071ba5f0769348e1337f Mon Sep 17 00:00:00 2001 From: Anna Sidwell Date: Thu, 7 Mar 2019 09:15:18 +0000 Subject: [PATCH] Put case study editing behind a feature flag --- apps/map/views.py | 3 +++ apps/profiles/views.py | 4 ++++ ojusomap/settings.py | 3 +++ ojusomap/templates/auth/user_detail.html | 4 +++- 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/apps/map/views.py b/apps/map/views.py index a51c8fc..905c82d 100644 --- a/apps/map/views.py +++ b/apps/map/views.py @@ -166,6 +166,9 @@ class EditCaseStudy(UserPassesTestMixin, BaseEditForm): form_class = ShortCaseStudyForm def test_func(self): + if settings.FFCAN_EDIT is False: + return False + object = self.get_object() if object.author: author = object.author.id diff --git a/apps/profiles/views.py b/apps/profiles/views.py index 4d4b487..60623dd 100644 --- a/apps/profiles/views.py +++ b/apps/profiles/views.py @@ -3,6 +3,8 @@ try: except ImportError: from django.core.urlresolvers import reverse +from django.conf import settings + from django.views.generic import DetailView, ListView, RedirectView, UpdateView from django.contrib.auth.mixins import LoginRequiredMixin @@ -28,6 +30,8 @@ class UserDetailView(LoginRequiredMixin, DetailView): case_studies = CaseStudy.objects.filter(author=self.request.user.id) context['case_studies'] = case_studies + context['enable_edit'] = settings.FF_CAN_EDIT + return context diff --git a/ojusomap/settings.py b/ojusomap/settings.py index 7a90b99..b95634c 100644 --- a/ojusomap/settings.py +++ b/ojusomap/settings.py @@ -359,3 +359,6 @@ from django.contrib.messages import constants as messages MESSAGE_TAGS = { messages.ERROR: 'danger' } + +# Feature flags +FF_CAN_EDIT = False diff --git a/ojusomap/templates/auth/user_detail.html b/ojusomap/templates/auth/user_detail.html index 362e696..9dd18f8 100644 --- a/ojusomap/templates/auth/user_detail.html +++ b/ojusomap/templates/auth/user_detail.html @@ -40,8 +40,10 @@ {% if case.language %}{{ case.language }}{% else %}-{% endif %} {% if case.approved %}Yes{% else %}No{% endif %} - View | + View + {% if enable_edit %} | Edit + {% endif %} {% endfor %}