From bbe6f6451abdd92e51f607b2e8e6bdc0dd74d141 Mon Sep 17 00:00:00 2001 From: naomi Date: Sun, 12 Sep 2021 10:22:30 +0200 Subject: [PATCH 01/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index 3288583..5455cf1 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -1,7 +1,7 @@ # First - Log in as a user with the role "GNO Standard User". -# Client & training & project +# Client & training - Billing fields are not there at first but there is a button to add them and when you click it is adds them. - Save the client without filling in any billing fields, then edit it - the fields should be gone and the button shoud be there - Add one or more billing fields, save and edit - all the billing fields should show, and not the button. @@ -15,9 +15,6 @@ - Save it, the trainers and rates should show , then when you edit it again the input box should be gone for the none one and disabled for the standard - The training immediately shows up in the training list for that client - It also appears in "All trainings", at the top - - Add a project and add multiple fees - - Save it and all the fees should be displayed - - The project should appear in the project list for the client and also in All Projects # Umbrella client @@ -104,7 +101,7 @@ # Total fees on a project * Create a project and add some fees -* When you view the project the total fee should be displayed +* When you view the project the fees should be listed and also total fee should be displayed * Edit it and change a fee, delete a fee, add a fee * The total should update -* The total should appear in the list of projects \ No newline at end of file +* The project along with its total fee should appear in the All Projects list \ No newline at end of file From 092fcd7f5ae8c6ab07e4b386ebad22d53e0d106f Mon Sep 17 00:00:00 2001 From: naomi Date: Sun, 12 Sep 2021 10:31:37 +0200 Subject: [PATCH 02/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index 5455cf1..27e9b11 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -14,7 +14,7 @@ - Add another trainer with "None" rate and one with Standard - Save it, the trainers and rates should show , then when you edit it again the input box should be gone for the none one and disabled for the standard - The training immediately shows up in the training list for that client - - It also appears in "All trainings", at the top + - It also appears in "All trainings" # Umbrella client From 05bc0b7fc67b5c1e641e660096448ecd1b15ec94 Mon Sep 17 00:00:00 2001 From: naomi Date: Sun, 12 Sep 2021 10:37:32 +0200 Subject: [PATCH 03/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index 27e9b11..a86ec94 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -96,8 +96,9 @@ * Create a debrief for a training and fill in "Number of participants". * The number should appear on the training when you view it. -* Edit the debreief - it should change the training too -* Create another - so should that +* Edit the debrief to set a different number - it should overwrite the number on the training +* Create another debrief - should also overwrite +* Delete a debrief - number on training should not change # Total fees on a project * Create a project and add some fees From 3af2561c3e78445b7ed6ec1db73b78ec676ac167 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 10:37:54 +0200 Subject: [PATCH 04/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index a86ec94..e94a69d 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -63,14 +63,14 @@ * The subtypes dropdown should be populated according to the existing value of the types dropdown. E.g. save a client as "licensed premises" type and reopen; the subtypes should be a list including "Pub or Bar" * The status dropdown should be populated according to the existing value of the substatuses dropdown. E.g. save a client as substatus "One-off Training" and reopen; the status should be set to "Confirmed" and that should be the only option in the status dropdown. -# Automatic client status +# Automatic client status & accreditation date ## Tests for presave hook in goodnightout_opencase.module * Setup a client with status "Lead" and give it multiple trainings - leave the training status as N/A. * Set some but not all of the trainings to status "post training materials sent" * The status of the client should not change * Set all the remaining trainings to status "post training materials sent" -* This should automatically set the client status to "Accredited" and their substatus to "Recently Accredited" +* This should automatically set the client status to "Accredited", their substatus to "Recently Accredited", and their Accreditation Date to today. # Trainings linked to projects or clients From b3b0eb2e6c4f17140af0c33e718f5ede3be65a16 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 12:46:39 +0200 Subject: [PATCH 05/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index e94a69d..2e5f0b1 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -72,6 +72,15 @@ * Set all the remaining trainings to status "post training materials sent" * This should automatically set the client status to "Accredited", their substatus to "Recently Accredited", and their Accreditation Date to today. +## Tests for cron hook in goodnightout_opencase.module + +* Change the accreditation date to one that's more than 3 months in the past +* Run cron +* The status should change to 3-month follow-up due and an email alert should be sen +* Change the status to "3-month follow-up sent" and change the accreditation date to one that's more than 6 months in the past +* Run cron +* The status should change to 6-month follow-up due and an email alert should be sent + # Trainings linked to projects or clients * Add a training from a client screen From afa5e7e37d3b6ece794691351e83923683c23491 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 12:48:38 +0200 Subject: [PATCH 06/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index 2e5f0b1..fad1124 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -63,24 +63,6 @@ * The subtypes dropdown should be populated according to the existing value of the types dropdown. E.g. save a client as "licensed premises" type and reopen; the subtypes should be a list including "Pub or Bar" * The status dropdown should be populated according to the existing value of the substatuses dropdown. E.g. save a client as substatus "One-off Training" and reopen; the status should be set to "Confirmed" and that should be the only option in the status dropdown. -# Automatic client status & accreditation date -## Tests for presave hook in goodnightout_opencase.module - -* Setup a client with status "Lead" and give it multiple trainings - leave the training status as N/A. -* Set some but not all of the trainings to status "post training materials sent" -* The status of the client should not change -* Set all the remaining trainings to status "post training materials sent" -* This should automatically set the client status to "Accredited", their substatus to "Recently Accredited", and their Accreditation Date to today. - -## Tests for cron hook in goodnightout_opencase.module - -* Change the accreditation date to one that's more than 3 months in the past -* Run cron -* The status should change to 3-month follow-up due and an email alert should be sen -* Change the status to "3-month follow-up sent" and change the accreditation date to one that's more than 6 months in the past -* Run cron -* The status should change to 6-month follow-up due and an email alert should be sent - # Trainings linked to projects or clients * Add a training from a client screen @@ -101,6 +83,24 @@ * Should not happen when client is saved without changing status * Should not happen when status is changed to something else +# Automatic client status & accreditation date +## Tests for presave hook in goodnightout_opencase.module + +* Setup a client with status "Lead" and give it multiple trainings - leave the training status as N/A. +* Set some but not all of the trainings to status "post training materials sent" +* The status of the client should not change +* Set all the remaining trainings to status "post training materials sent" +* This should automatically set the client status to "Accredited", their substatus to "Recently Accredited", and their Accreditation Date to today. + +## Tests for cron hook in goodnightout_opencase.module + +* Change the accreditation date to one that's more than 3 months in the past +* Run cron +* The status should change to 3-month follow-up due and an email alert should be sen +* Change the status to "3-month follow-up sent" and change the accreditation date to one that's more than 6 months in the past +* Run cron +* The status should change to 6-month follow-up due and an email alert should be sent + # Number of participants * Create a debrief for a training and fill in "Number of participants". From 17f9ce60b794915ff6dd06003293f0a51f8baf4d Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 13:25:22 +0200 Subject: [PATCH 07/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index fad1124..cea8285 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -114,4 +114,20 @@ * When you view the project the fees should be listed and also total fee should be displayed * Edit it and change a fee, delete a fee, add a fee * The total should update -* The project along with its total fee should appear in the All Projects list \ No newline at end of file +* The project along with its total fee should appear in the All Projects list + +## Unpublishing entities + +* All these entities should have a button to unpublish them: + * Client + * Umbrella Client + * Training + * Project + * Train the trainer event + * Partner Organistion + * Equal Opps record +* Clicking it should make them disappear from the "All" lists and also from the following contextual lists: + * List of trainings on client & umbrella client screens + * List of projects on client & umbrella client screens screen + * List of clients on umbrella client screens +* The "All" lists should have a link to show unpublished entities and clicking it should take you to a page showing them. (The contextual lists do not have this.) \ No newline at end of file From 7f97242cc67e6b9778e8141396503d6a1e6ce0d0 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 13:43:13 +0200 Subject: [PATCH 08/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index cea8285..d0e53fa 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -116,8 +116,9 @@ * The total should update * The project along with its total fee should appear in the All Projects list -## Unpublishing entities - +## Unpublishing and deleting entities +### As a GNO Standard User +* There should be no delete tab on any entities * All these entities should have a button to unpublish them: * Client * Umbrella Client @@ -125,9 +126,12 @@ * Project * Train the trainer event * Partner Organistion - * Equal Opps record * Clicking it should make them disappear from the "All" lists and also from the following contextual lists: * List of trainings on client & umbrella client screens * List of projects on client & umbrella client screens screen * List of clients on umbrella client screens -* The "All" lists should have a link to show unpublished entities and clicking it should take you to a page showing them. (The contextual lists do not have this.) \ No newline at end of file + +### As a GNO Admin user +* Unpublished entities should appear in all the lists, but in grey +* You should be able to delete all entities +* When you delete a training it should warn you it's going to delete the debriefs and evaulations as well. \ No newline at end of file From 8c4a00be64302e2e7972f6f4190ac919e102eda5 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 15:53:29 +0200 Subject: [PATCH 09/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index d0e53fa..ab067fc 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -118,15 +118,15 @@ ## Unpublishing and deleting entities ### As a GNO Standard User -* There should be no delete tab on any entities -* All these entities should have a button to unpublish them: +* There should be no delete tab on any entities (although you can delete links between clients) +* All these entities should a checkbox for whether they are published: * Client * Umbrella Client * Training * Project * Train the trainer event * Partner Organistion -* Clicking it should make them disappear from the "All" lists and also from the following contextual lists: +* Untick and save - you should get Access Denied and the entity should have disappeared from the "All" lists and also from the following contextual lists: * List of trainings on client & umbrella client screens * List of projects on client & umbrella client screens screen * List of clients on umbrella client screens From e178d594e9273a8024043ba7c27bf9eb15f2b478 Mon Sep 17 00:00:00 2001 From: naomi Date: Mon, 13 Sep 2021 16:53:01 +0200 Subject: [PATCH 10/10] Update 'docs/manual_tests.md' --- docs/manual_tests.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/manual_tests.md b/docs/manual_tests.md index ab067fc..a849da9 100644 --- a/docs/manual_tests.md +++ b/docs/manual_tests.md @@ -126,12 +126,20 @@ * Project * Train the trainer event * Partner Organistion + * debrief + * Evaluation * Untick and save - you should get Access Denied and the entity should have disappeared from the "All" lists and also from the following contextual lists: * List of trainings on client & umbrella client screens * List of projects on client & umbrella client screens screen * List of clients on umbrella client screens + * List of debriefs and evaluations on trainings screen +* Unpublished entities should not show up in any autocomplete fields. i.e.: + * Unpublished trainers should not come up as an option when filling in the trainer field on a training + * Unpublished clients should not come up as an option when filling in the client field of a training or a project, or when adding a linked client to another client + * Unpublished projects should not come up as an option when filling in the project field of a training + * Unpublished umbrella clients should not come up as an option when filling in the umbrella client field of a client ### As a GNO Admin user -* Unpublished entities should appear in all the lists, but in grey +* Unpublished entities should appear in all the lists, but in grey (and should not show up in autocomplete fields) * You should be able to delete all entities * When you delete a training it should warn you it's going to delete the debriefs and evaulations as well. \ No newline at end of file