.env.sample contain hard-coded domains which we could search/replace #111

New Issue

decentral1se · 2021-03-19T21:58:37Z

decentral1se commented

2021-03-19 21:58:37 +00:00

oh, and I used --domain yet the config had the domain set to git.autonomic.zone :D

577f3668ea/.env.sample (L4)

> oh, and I used --domain yet the config had the domain set to git.autonomic.zone :D https://git.autonomic.zone/coop-cloud/gitea/src/commit/577f3668ea20107e00ce0e379116fd0f0ed14874/.env.sample#L4

decentral1se added this to the Beta release milestone 2021-03-19 21:58:37 +00:00

decentral1se added the

enhancement

label 2021-03-19 21:58:37 +00:00

decentral1se changed title from ~~.env.samples contain hard-coded domains which we could search/replace~~ to .env.sample contain hard-coded domains which we could search/replace

2021-03-19 21:59:52 +00:00

3wordchant commented

2021-03-20 11:31:21 +00:00

Only ones I can find are gitea and invoiceninja:

$ rg --type-add 'env:*.env.sample' -tenv --hidden autonomic.zone
invoiceninja/.env.sample
3:DOMAIN=invoiceninja.swarm.autonomic.zone

gitea/.env.sample
4:DOMAIN=git.autonomic.zone
7:GITEA_DOMAIN=git.autonomic.zone
16:GITEA_MAILER_FROM=noreply@autonomic.zone
18:GITEA_MAILER_USER=noreply@autonomic.zone

selfoss/.env.sample
26:# 	https://git.autonomic.zone/compose-stacks/selfoss/issues/3

Only ones I can find are `gitea` and `invoiceninja`: ``` $ rg --type-add 'env:*.env.sample' -tenv --hidden autonomic.zone invoiceninja/.env.sample 3:DOMAIN=invoiceninja.swarm.autonomic.zone gitea/.env.sample 4:DOMAIN=git.autonomic.zone 7:GITEA_DOMAIN=git.autonomic.zone 16:GITEA_MAILER_FROM=noreply@autonomic.zone 18:GITEA_MAILER_USER=noreply@autonomic.zone selfoss/.env.sample 26:# https://git.autonomic.zone/compose-stacks/selfoss/issues/3 ```

3wordchant referenced this issue from a commit

2021-03-20 12:50:29 +00:00

autonomic.zone -> example.com

3wordchant referenced this issue from a commit

2021-03-20 12:52:42 +00:00

Remove hard-coded autonomic.zone

3wordchant closed this issue

2021-03-20 12:52:49 +00:00

decentral1se commented

2021-03-20 20:25:51 +00:00

Thank you! I added 4251c32b30 (wording can probably be better?) to emphasise that you probably need to edit the config before deploying in any case. I think that also might stop people getting caught with deploying an app with a config that won't work for them.

Thank you! I added https://git.autonomic.zone/coop-cloud/abra/commit/4251c32b3091fdfdbe3ab5a40806cd0cfb630efd (wording can probably be better?) to emphasise that you probably need to edit the config before deploying in any case. I think that also might stop people getting caught with deploying an app with a config that won't work for them.

3wordchant commented

2021-03-21 13:14:42 +00:00

you probably need to edit the config before deploying in any case

It's different per-app: a lot of them are unlikely to need any config because the only relevant var is $DOMAIN which is set automatically. But I think the new message in 4251c32b30 is better for the time being, yeah 👌

> you probably need to edit the config before deploying in any case It's different per-app: a lot of them are unlikely to need any config because the only relevant var is `$DOMAIN` which is set automatically. But I think the new message in 4251c32b30 is better for the time being, yeah 👌

3wordchant commented

2021-03-21 13:34:11 +00:00

Proposal for offering to run config / deploy automagically: #114

Proposal for offering to run `config` / `deploy` automagically: #114

🎉 1

This repo is archived. You cannot comment on issues.