Reconsidering domain polling for now #169

New Issue

decentral1se · 2021-05-31T21:56:00Z

decentral1se commented

2021-05-31 21:56:00 +00:00

I don't think it should be on by default now. But also, I don't think I'd even use it then because it is so flaky. Then I started to wonder if we should even have this in now at all.

Without the solid base of #165 I don't think we can do domain polling in any reliable way. For example, if we can't tell the deployment definitely succeeded then we could be polling without reason when all the containers fell down. Also, if the containers come up but they're not healthy then traefik won't route them and we're polling for no reason. And if the containers come up successfully but keep erroring out in the logs then we're polling for no reason.

Maybe domain polling should be ripped out for now or made non-default (--no-domain-poll becomes --domain-poll) until we have #165 done well.

I guess having a reliable domain polling setup is beta level polish.

Thoughts?

I don't think it should be on by default now. But also, I don't think I'd even use it then because it is so flaky. Then I started to wonder if we should even have this in now at all. Without the solid base of https://git.autonomic.zone/coop-cloud/abra/issues/165 I don't think we can do domain polling in any reliable way. For example, if we can't tell the deployment definitely succeeded then we could be polling without reason when all the containers fell down. Also, if the containers come up but they're not healthy then traefik won't route them and we're polling for no reason. And if the containers come up successfully but keep erroring out in the logs then we're polling for no reason. Maybe domain polling should be ripped out for now or made non-default (`--no-domain-poll` becomes `--domain-poll`) until we have https://git.autonomic.zone/coop-cloud/abra/issues/165 done well. I guess having a reliable domain polling setup is beta level polish. Thoughts?

decentral1se added this to the Beta release milestone 2021-05-31 21:56:00 +00:00

decentral1se added the

question

breaking-change

labels 2021-05-31 21:56:00 +00:00

~~decentral1se referenced this issue from coop-cloud/organising 2021-06-04 14:27:42 +00:00~~

App CI/CD test suite brainstorming #69

decentral1se commented

2021-06-08 09:07:29 +00:00

Actually, was thinking, maybe just --fast is good enough! We could drop all the --no-* options and then it is just a simpler CLI experience overall. I will get a PR out.

Actually, was thinking, maybe just `--fast` is good enough! We could drop all the `--no-*` options and then it is just a simpler CLI experience overall. I will get a PR out.

decentral1se referenced this issue from a commit

2021-06-08 09:13:06 +00:00

Prefer --fast for skipping all checks

decentral1se referenced this issue

2021-06-08 09:14:50 +00:00

Prefer --fast for skipping all checks #175

decentral1se referenced this issue from a commit

2021-06-08 10:28:45 +00:00

Prefer --fast for skipping all checks

decentral1se referenced this issue from a commit

2021-06-10 22:28:35 +00:00

Prefer --fast for skipping all checks