Make ensure_stack_deployed more reliable #177
No reviewers
Labels
No Label
breaking-change
bug
CI/CD
design
documentation
duplicate
enhancement
help wanted
invalid
plugin
question
secrets
shell-completion
versioning
wontfix
No Milestone
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#177
Loading…
Reference in New Issue
No description provided.
Delete Branch "improved-stack-deploy-guarantees"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #165.
Cases to be solved from my testing:
Overall goals are: make it work and keep it fast.
All of these will rely on healthchecks on each container, so, we need to implement them in all our apps and make them standard from now on, unfortunately...but I am getting better at understanding how they work! I have hope.
Seems like a default new
deploy: ...
configuration is emerging:Where you ensure that the service won't be in a restart loop forever.
f151018f10
toc7f838178c
It seems a core element of making this run fast is configuring the healthcheck:
The default settings are really default. A redis container is up in like 3 seconds but the first healthcheck won't run until 30 seconds. So by tailoring each of these values to some better default, we can get speedy deployments and
abra
doesn't have to manage it. It pushes the complexity to swarm itself which is ideal.Also:
c7f838178c
to4ed9f119d8
4ed9f119d8
to7322105fd9
7322105fd9
to4593451dab
4593451dab
to62999a1732
OK, I'm gonna merge this as is now, one edge case is still not covered. Example output:
62999a1732
todccfff0c87
dccfff0c87
to93714a593b
WIP: make ensure_stack_deployed reliableto Make ensure_stack_deployed more reliable