Trying to handle exit codes in sub_app_run breaks interactive shells #204

New Issue

3wordchant · 2021-07-10T12:51:53Z

3wordchant commented

2021-07-10 12:51:53 +00:00

abra app foobar run app bash was immediately exiting for me.

Some git-bisecting later, it looks like this stopped working after b2e0a95a11.

I reverted that commit and it's back in action.

I couldn't find anything about how to put an interactive command in an if statement, I wonder if we have to do a shellcheck-saddening check of the exit code instead?

`abra app foobar run app bash` was immediately exiting for me. Some `git-bisect`ing later, it looks like this stopped working after b2e0a95a111ebe24e890993fb6fd64221afd2192. I reverted that commit and it's back in action. I couldn't find anything about how to put an interactive command in an `if` statement, I wonder if we have to do a shellcheck-saddening check of the exit code instead?

3wordchant added the

bug

label 2021-07-10 12:51:53 +00:00

decentral1se referenced this issue from a commit

2021-07-10 14:00:47 +00:00

Attempt to unbork interactive breakage

decentral1se commented

2021-07-10 14:01:39 +00:00

Oh nice, thanks for catching that and sorry for the inconvenience. I've pushed 3d5d3ff3ac and tested it and it seems to be working again? Let me know if not, will try to fix up again.

Oh nice, thanks for catching that and sorry for the inconvenience. I've pushed https://git.autonomic.zone/coop-cloud/abra/commit/3d5d3ff3ac22f550f0bd1d34a86fda7fdfdd1f25 and tested it and it seems to be working again? Let me know if not, will try to fix up again.

❤️ 1

decentral1se closed this issue

2021-07-10 14:01:39 +00:00

3wordchant commented

2021-07-11 20:04:59 +00:00

looks gr8 thank you! 🙏🙏

This repo is archived. You cannot comment on issues.