SECRET_KEY_BASE env var name auto generates as KEY_BASE #39

Closed
opened 2020-11-06 11:09:47 +00:00 by decentral1se · 3 comments
Owner

When generating secrets, because SECRET_ is in the actual app naming of the secret to be generated, this doesnt work, because our logic strips away SECRET_ and it ends up as KEY_BASE.

export SECRET_KEY_BASE_VERSION=v1
Generating key_base, version: v1, length: 30
Password: foobar

I would expect secret_key_base to match what the app expects.

I would then call it SECRET_SECRET_KEY_BASE or just KEY_BASE but that I can imagine is a bit of a weird work-around that will probably trip people up when they want to use this. Maybe we just need to document it really well. Unsure.

When generating secrets, because `SECRET_` is in the actual app naming of the secret to be generated, this doesnt work, because our logic strips away `SECRET_` and it ends up as `KEY_BASE`. ``` export SECRET_KEY_BASE_VERSION=v1 ``` ``` Generating key_base, version: v1, length: 30 Password: foobar ``` I would expect `secret_key_base` to match what the app expects. I would then call it `SECRET_SECRET_KEY_BASE` or just `KEY_BASE` but that I can imagine is a bit of a weird work-around that will probably trip people up when they want to use this. Maybe we just need to document it really well. Unsure.
Author
Owner

export SECRET_SECRET_KEY_BASE_VERSION=v1 # length=30 works for now!

`export SECRET_SECRET_KEY_BASE_VERSION=v1 # length=30` works for now!
Owner

SECRET_SECRET_KEY_... seems silly but not terrible to me.

What about documenting this oddness, and coming back to it if'n'when we change the app config format?

`SECRET_SECRET_KEY_...` seems silly but not terrible to me. What about documenting this oddness, and coming back to it if'n'when we change the app config format?
decentral1se added the
documentation
label 2020-12-27 11:12:41 +00:00
Author
Owner

Handling this will happen outside of the abra repo so I'll close this off.

Handling this will happen outside of the abra repo so I'll close this off.
This repo is archived. You cannot comment on issues.
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#39
No description provided.