Use set +a to load env variables, drop export #40

New Issue

3wordchant · 2020-11-10T11:11:22Z

3wordchant commented

2020-11-10 11:11:22 +00:00

Currently, our env files use dotenv / direnv format, where we export variables, e.g.

export APP=traefik

If we switched to .env format (the common 12-factor app pattern, i.e. without export), we could use the same file for both docker-compose, which loads .env from the current directory automatically, and abra, which can use set +a to automatically export variables from a loaded file:

set +a
source /path/to/env.env
set -a

Doing grep -lR 'export ' | sed -i 's/export //' across all the stacks should get us most of the way to the switch.

Currently, our env files use dotenv / direnv format, where we `export` variables, [e.g.](https://git.autonomic.zone/coop-cloud/traefik/src/branch/master/.envrc.sample#L1) `export APP=traefik` If we switched to `.env` format (the common 12-factor app pattern, i.e. without `export`), we could use the same file for both `docker-compose`, which loads `.env` from the current directory automatically, and `abra`, which can use `set +a` to automatically export variables from a loaded file: ``` set +a source /path/to/env.env set -a ``` Doing `grep -lR 'export ' | sed -i 's/export //'` across all the stacks should get us most of the way to the switch.

🚀 1

3wordchant added the

enhancement

label 2020-11-10 11:11:36 +00:00

decentral1se added the

breaking-change

label 2020-12-29 16:13:31 +00:00

decentral1se referenced this issue from a commit

2020-12-29 16:57:45 +00:00

Use set -a/+a and docker env file formats

decentral1se referenced this issue

2020-12-29 16:59:58 +00:00

Use set -a/+a and docker env file formats #55

decentral1se referenced this issue from a commit

2020-12-29 17:00:22 +00:00

Use set -a/+a and docker env file formats

decentral1se referenced this issue from a commit

2020-12-29 17:01:18 +00:00

Use set -a/+a and docker env file formats

decentral1se referenced this issue from a commit

2020-12-29 17:17:06 +00:00

Use set -a/+a and docker env file formats

decentral1se commented

2020-12-29 17:18:05 +00:00

When #55 is in some mergeable state and goes in, we'll need to update our app repos to use .env.sample and not .envrc.sample as well as removing all the export usages 🚒

When https://git.autonomic.zone/coop-cloud/abra/pulls/55 is in some mergeable state and goes in, we'll need to update our app repos to use `.env.sample` and not `.envrc.sample` as well as removing all the `export` usages 🚒

decentral1se referenced this issue from a commit

2020-12-30 10:22:38 +00:00

Use set -a/+a and docker env file formats

decentral1se referenced this issue from a commit

2020-12-30 10:23:05 +00:00

Use set -a/+a and docker env file formats

decentral1se closed this issue

2020-12-30 10:23:31 +00:00

decentral1se commented

2020-12-30 10:25:33 +00:00

Something like adcb53b61c and 5d3fa1ad4f does the trick with the new abra changes.

Something like https://git.autonomic.zone/coop-cloud/gitea/commit/adcb53b61c52b4514be55ba8af72d8d5e01c641c and https://git.autonomic.zone/coop-cloud/gitea/commit/5d3fa1ad4f912b11d28253b852e1d3b4a524dddc does the trick with the new abra changes.

3wordchant referenced this issue from a commit

Use set +a to load env variables, drop export #40

Use `set +a` to load env variables, drop `export` #40