Shell completion #5

New Issue

3wordchant · 2020-09-08T15:02:38Z

3wordchant commented

2020-09-08 15:02:38 +00:00

Maybe overkill depending on how long we think this janky Bash implementation is gonna exist for, but it'd be nice to have completion of commands and their arguments.

3wordchant added the

enhancement

label 2020-09-13 16:00:22 +00:00

decentral1se commented

2020-10-30 16:45:29 +00:00

https://git.autonomic.zone/coop-cloud/abra/src/branch/main/completion.bash

Apparently zsh can also handle, I tried:

➜  abra (main) ✔ autoload bashcompinit; bashcompinit
➜  abra (main) ✔ source completion.bash
➜  abra (main) ✔ ./abra _abra_complete:2: compopt: function definition file not found

This seems to be some sort of incompatibility with versions.

> https://git.autonomic.zone/coop-cloud/abra/src/branch/main/completion.bash Apparently `zsh` can also handle, I tried: ``` ➜ abra (main) ✔ autoload bashcompinit; bashcompinit ➜ abra (main) ✔ source completion.bash ➜ abra (main) ✔ ./abra _abra_complete:2: compopt: function definition file not found ``` This seems to be some sort of incompatibility with versions.

3wordchant referenced this issue from a commit

2020-10-30 19:41:08 +00:00

Handle missing `compopt` Ref #5

3wordchant commented

2020-10-30 19:43:32 +00:00

I re-added some copypasta from homeshick which claims to handle missing compopt, that work any better?

I re-added some copypasta from homeshick which claims to handle missing `compopt`, that work any better?

decentral1se commented

2020-10-31 19:33:21 +00:00

Thanks! Still same issue... I guess some further digging is required for Zsh.

Feel free to close this one off on your side for Bash, looks legit :)

Thanks! Still same issue... I guess some further digging is required for Zsh. Feel free to close this one off on your side for Bash, looks legit :)

3wordchant referenced this issue from a commit

2020-11-01 13:23:26 +00:00

Whoops! (Actual `compopt` fix Ref #5

3wordchant commented

2020-11-01 13:24:46 +00:00

Ugh embarrassing copypasta error, forgot to s/HOMESHICK/ABRA in one place. Any joy now? If still no I might install zsh under protest.

Ugh embarrassing copypasta error, forgot to `s/HOMESHICK/ABRA` in one place. Any joy now? If still no I might install `zsh` under protest.

decentral1se commented

2020-11-01 15:16:38 +00:00

Oh! But no... haha, sorry!

➜  abra (main) ✔ autoload bashcompinit; bashcompinit
➜  abra (main) ✔ source completion.bash
➜  abra (main) ✔ ./abra _abra_complete:52: command not found: mapfile

I tried https://stackoverflow.com/questions/53975551/how-to-load-zsh-mapfile-in-zsh but then I also saw:

./abra app _abra_apps:4: command not found: shopt

Guess those are Bash only functions or!? Pretty lost with this stuff...

Oh! But no... haha, sorry! ``` ➜ abra (main) ✔ autoload bashcompinit; bashcompinit ➜ abra (main) ✔ source completion.bash ➜ abra (main) ✔ ./abra _abra_complete:52: command not found: mapfile ``` I tried https://stackoverflow.com/questions/53975551/how-to-load-zsh-mapfile-in-zsh but then I also saw: ``` ./abra app _abra_apps:4: command not found: shopt ``` Guess those are Bash only functions or!? Pretty lost with this stuff...

decentral1se commented

2020-11-01 16:21:52 +00:00

Lol, ok, using abra more and more (it is awesome) but I can now say that it is maybe not so RSI friendly hehe, many typingz of domain required! Maybe abra app deploy and then selection screen will be good too. Will come back to this...

Lol, ok, using `abra` more and more (it is awesome) but I can now say that it is maybe not so RSI friendly hehe, many typingz of domain required! Maybe `abra app deploy` and then selection screen will be good too. Will come back to this...

3wordchant commented

2020-11-01 17:11:15 +00:00

Yeah I had the same hand-health concerns 😬 Both mapfile and shopt are Bash hacks to load things into arrays, I guess zsh has better ones, and writing a separate version of the script might be easier than making the Bash one cross-compatible. I'll give it a go unless you get there first.

Yeah I had the same hand-health concerns 😬 Both `mapfile` and `shopt` are Bash hacks to load things into arrays, I guess `zsh` has better ones, and writing a separate version of the script might be easier than making the Bash one cross-compatible. I'll give it a go unless you get there first.

3wordchant referenced this issue from a commit

2020-11-01 19:09:40 +00:00

Add zsh completion, remove compat hacks from bash Ref #5

decentral1se commented

2020-11-01 19:22:57 +00:00

Works for Zsh now too 🖤

decentral1se closed this issue

2020-11-01 19:22:57 +00:00

This repo is archived. You cannot comment on issues.