Merge app secret auto functionality into app secret generate? #58

New Issue

decentral1se · 2020-12-30T10:39:56Z

decentral1se commented

2020-12-30 10:39:56 +00:00

What we have now:

abra [options] app <domain> secret auto [--pass]
abra [options] app <domain> secret generate <secret> <version> [<cmd>] [--pass]

Maybe we could do something like? And drop auto and merge it in here.

abra [options] app <domain> secret generate [--secret] [--version] [<cmd>] [--pass]

So abra app secret generate by default will do the auto functionality. And if you want to handle a specific secret/version, you pass -s foo -v v1 and get it done that way.

Whatcha think?

What we have now: ``` abra [options] app <domain> secret auto [--pass] abra [options] app <domain> secret generate <secret> <version> [<cmd>] [--pass] ``` Maybe we could do something like? And drop `auto` and merge it in here. ``` abra [options] app <domain> secret generate [--secret] [--version] [<cmd>] [--pass] ``` So `abra app secret generate` by default will do the `auto` functionality. And if you want to handle a specific secret/version, you pass `-s foo -v v1` and get it done that way. Whatcha think?

decentral1se added the

question

design

breaking-change

labels 2020-12-30 10:39:56 +00:00

3wordchant commented

2020-12-30 10:42:25 +00:00

Sounds A+, let's do it

👍 1

decentral1se removed the

question

label 2020-12-30 21:43:25 +00:00

decentral1se self-assigned this 2020-12-30 21:43:32 +00:00

decentral1se commented

2020-12-31 17:32:27 +00:00

Oh, I realised there was a nice setup on abra secret rm so I will match:

  abra [options] app <app> secret generate (<secret> <version>|--all) [<cmd>] [--pass]
  abra [options] app <app> secret insert <secret> <version> <data> [--pass]
  abra [options] app <app> secret (delete|rm) (<secret>|--all) [--pass] [--force]

So abra app app1 secret generate --all matches abra app app1 secret rm --all.

Oh, I realised there was a nice setup on `abra secret rm` so I will match: ``` abra [options] app <app> secret generate (<secret> <version>|--all) [<cmd>] [--pass] abra [options] app <app> secret insert <secret> <version> <data> [--pass] abra [options] app <app> secret (delete|rm) (<secret>|--all) [--pass] [--force] ``` So `abra app app1 secret generate --all` matches `abra app app1 secret rm --all`.

decentral1se referenced this issue from a commit

2021-01-01 16:28:03 +00:00

Merge auto/generate and use --secrets

decentral1se referenced this issue

2021-01-01 16:28:33 +00:00

Merging auto functionality into generate command #64

decentral1se referenced this issue from a commit

2021-01-01 16:31:30 +00:00

Merge auto/generate and use --secrets

decentral1se closed this issue

2021-01-01 16:32:32 +00:00

This repo is archived. You cannot comment on issues.