Use docker-compose words for deletion: undeploy -> stop, rm -> down #59

Closed
opened 2020-12-30 10:49:44 +00:00 by decentral1se · 5 comments
Owner
abra [options] app <domain> undeploy
abra [options] app <domain> (delete|rm) [--force]

AFAIU, undeploy does a stack rm and delete|rm does a deletion of the ~/.abra/.../<domain>.env file? Would be nice to have one interface for doing these two operations as they are related.

An idea:

abra [options] app <domain> rm [--env] [--force]

Where default abra app rm just does a stack rm and you pass --env to also nuke the local env file as well. Don't mind on rm but you know my typing bias ;)

``` abra [options] app <domain> undeploy abra [options] app <domain> (delete|rm) [--force] ``` AFAIU, `undeploy` does a `stack rm` and `delete|rm` does a deletion of the `~/.abra/.../<domain>.env` file? Would be nice to have one interface for doing these two operations as they are related. An idea: ``` abra [options] app <domain> rm [--env] [--force] ``` Where default `abra app rm` just does a `stack rm` and you pass `--env` to **also** nuke the local env file as well. Don't mind on `rm` but you know my typing bias ;)
decentral1se added the
question
design
breaking-change
labels 2020-12-30 10:49:44 +00:00
Author
Owner

Oh, better keep #44 in mind.

Oh, better keep [#44](https://git.autonomic.zone/coop-cloud/abra/issues/44) in mind.
Owner

Awesome yeah, let's keep the CLI simplification ideas comin'.

From my warped and too-close perspective, as long as we have new and deploy separate, it seems semi-reasonable to have separate rm and undeploy commands too -- undeploy is completely non-destructive and reversible whereas deleting the .env file could easily lose information, and undeploy is more like a deactivate than deleting anything.

But yeah, I'm not necessarily representative of any other users, and undeploy is not exactly a common word 😬

Awesome yeah, let's keep the CLI simplification ideas comin'. From my warped and too-close perspective, as long as we have `new` and `deploy` separate, it seems semi-reasonable to have separate `rm` and `undeploy` commands too -- `undeploy` is completely non-destructive and reversible whereas deleting the `.env` file could easily lose information, and `undeploy` is more like a `deactivate` than deleting anything. But yeah, I'm not necessarily representative of any other users, and `undeploy` is not exactly a common word 😬
Author
Owner

Was thinking aboutrm [--soft] [--hard] but see your point about two commands as a clear separation of what is happening. Unsure. Maybe rm becomes down and undeploy becomes stop like docker-compose does? I actually got pretty fast what those meant IIRC.

Was thinking about`rm [--soft] [--hard]` but see your point about two commands as a clear separation of what is happening. Unsure. Maybe `rm` becomes `down` and `undeploy` becomes `stop` like `docker-compose` does? I actually got pretty fast what those meant IIRC.
decentral1se changed title from Merge app undeploy/(delete|rm) for one way to remove apps? to Use docker-compose words for deletion: undeploy -> stop, rm -> down 2020-12-31 13:35:05 +00:00
Author
Owner

OK, revised proposal is then (edited ticket name to reflect):

  • rm -> down
  • undeploy -> stop
OK, revised proposal is then (edited ticket name to reflect): - `rm` -> `down` - `undeploy` -> `stop`
Author
Owner

Not pushed about this now and seems fine, let's leave as is.

Not pushed about this now and seems fine, let's leave as is.
This repo is archived. You cannot comment on issues.
No Milestone
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#59
No description provided.