Use docker-compose words for deletion: undeploy -> stop, rm -> down #59
Labels
No Label
breaking-change
bug
CI/CD
design
documentation
duplicate
enhancement
help wanted
invalid
plugin
question
secrets
shell-completion
versioning
wontfix
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#59
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
AFAIU,
undeploy
does astack rm
anddelete|rm
does a deletion of the~/.abra/.../<domain>.env
file? Would be nice to have one interface for doing these two operations as they are related.An idea:
Where default
abra app rm
just does astack rm
and you pass--env
to also nuke the local env file as well. Don't mind onrm
but you know my typing bias ;)Oh, better keep #44 in mind.
Awesome yeah, let's keep the CLI simplification ideas comin'.
From my warped and too-close perspective, as long as we have
new
anddeploy
separate, it seems semi-reasonable to have separaterm
andundeploy
commands too --undeploy
is completely non-destructive and reversible whereas deleting the.env
file could easily lose information, andundeploy
is more like adeactivate
than deleting anything.But yeah, I'm not necessarily representative of any other users, and
undeploy
is not exactly a common word 😬Was thinking about
rm [--soft] [--hard]
but see your point about two commands as a clear separation of what is happening. Unsure. Mayberm
becomesdown
andundeploy
becomesstop
likedocker-compose
does? I actually got pretty fast what those meant IIRC.Merge app undeploy/(delete|rm) for one way to remove apps?to Use docker-compose words for deletion: undeploy -> stop, rm -> downOK, revised proposal is then (edited ticket name to reflect):
rm
->down
undeploy
->stop
Not pushed about this now and seems fine, let's leave as is.