No generation for secrets which have TOKEN in the name (no PASSWORD/KEY) #68

New Issue

decentral1se · 2020-12-31T15:50:11Z

decentral1se commented

2020-12-31 15:50:11 +00:00

I've now got a secret that has no KEY but TOKEN and it specifies a length=x comment. The thought occurred to me then we can just treat everything with the same PASSWORD logic, defaulting to pwqgen, but when we see length=x, we drop back to pwgen and use the length specifier.

This would simplify our logic which trys to match against a string with PASSWORD or KEY in it and then choose pwgen or pwqgen. This feels like a less brittle method.

I've now got a secret that has no `KEY` but `TOKEN` and it specifies a `length=x` comment. The thought occurred to me then we can just treat everything with the same `PASSWORD` logic, defaulting to `pwqgen`, but when we see `length=x`, we drop back to `pwgen` and use the length specifier. This would simplify our logic which trys to match against a string with `PASSWORD` or `KEY` in it and then choose `pwgen` or `pwqgen`. This feels like a less brittle method.

decentral1se added the

bug

label 2020-12-31 15:50:11 +00:00

3wordchant commented

2020-12-31 18:41:57 +00:00

Yep now that we have the SECRET_ convention I don't think we need to look for PASSWORD or KEY at all, let's do this.

Yep now that we have the `SECRET_` convention I don't think we need to look for `PASSWORD` or `KEY` at all, let's do this.

👍 1

decentral1se self-assigned this 2021-01-01 16:33:26 +00:00

decentral1se commented

2021-01-01 16:33:56 +00:00

Gonna squash this next 🏃