decentral1se decentral1se
  • Joined on 2020-03-23
decentral1se commented on pull request 3wordchant/capsul-flask#1 2021-07-20 22:09:47 +00:00
Add preliminary automated tests

You can get Pytest to run your Nosetests so I think you can just merge this as-is. See https://docs.pytest.org/en/6.2.x/nose.html for more.

decentral1se approved 3wordchant/capsul-flask#1 2021-07-20 21:09:08 +00:00
Add preliminary automated tests

LGTM! Super nice to get some tests in.

decentral1se commented on pull request 3wordchant/capsul-flask#2 2021-07-20 20:57:17 +00:00
Docker image, & local development docker-compose.yml

Off-topic: does capsul do tagged releases? That'd be handy as the plugins/docker plugin has a auto_tag: true which generates the image tag based on the git tag. That is probably One For Later ™️

decentral1se commented on pull request 3wordchant/capsul-flask#2 2021-07-20 20:57:17 +00:00
Docker image, & local development docker-compose.yml

Feel free to ignore but I usually add --no-cache to save space and newline + sort things so it is easier to have a visual overview of dependencies and alphabetic ordering to know where to slot things in. Can be useful if you end up adding a lot of dependencies and then need to remove them over time as the software changes.

decentral1se commented on pull request 3wordchant/capsul-flask#2 2021-07-20 20:57:17 +00:00
Docker image, & local development docker-compose.yml

Optional: var = os.environ.get(f"{var_name}_FILE") also works as it defaults to None if missing.

decentral1se approved 3wordchant/capsul-flask#2 2021-07-20 20:57:17 +00:00
Docker image, & local development docker-compose.yml

Fantastic work! All of my comments are mostly rambly commentary on not-necessary changes at all unless you feel like it. I had a glass of wine and I was enjoying typing. You'll have to forgive me.

decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 11:10:51 +00:00
309be57024 Drop that, done by scripts
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 11:09:25 +00:00
3d46d291bb Add drone note [ci skip]
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 11:07:54 +00:00
ffb949366a Separate paths
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 11:01:04 +00:00
7aec6b910c Fix CLI usage
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 11:00:06 +00:00
5a3364a5ec Output generated folder
53b16e9b4d Make pip quiet
Compare 2 commits »
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 10:57:56 +00:00
df77e2c0ad Use absolute path
c69d07ca9c Ignore repos
Compare 2 commits »
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 10:54:29 +00:00
f28a8c84d7 Shuffle paths again
ae60862a85 Fix file path
Compare 2 commits »
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 10:50:21 +00:00
92db098942 Try this fancy chdir command
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 10:46:11 +00:00
831637b99b Attempt to fix copying logic
decentral1se pushed to main at ruangrupa/pubscripts 2021-07-13 10:43:41 +00:00
73850d888a Add CI badge
decentral1se pushed to main at ruangrupa/beta.lumbung.space 2021-07-13 10:43:04 +00:00
235c20c5f7 Add volume