Block a user
decentral1se
commented on pull request autonomic-coopera…/autonomic.zone#18
2020-04-18 14:06:14 +00:00
Added Gitea logo to footer
LGTM!
I think the build failed because of the trigger setup on the .drone.yml file which still triggers the build but the ssh key secret is locked out of pull requests. I think the the following patch might fix that:
diff --git a/.drone.yml b/.drone.yml
index 2b6e593..29fe7cd 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -11,3 +11,6 @@ steps:
trigger:
branch:
- master
+ event:
+ exclude:
+ - pull_request
We just need something to ignore pull requests and only deploy on master merges. I was looking at https://docs.drone.io/pipeline/triggers/ for that.
Deploy on dokku.autonomic.zone
Add blog post about datpy project
decentral1se
commented on issue autonomic-coopera…/dokku-ansible-deploy#8
2020-04-16 11:14:46 +00:00
If you wire up bad mounts, they stay there after the deploy fails
You'd probably want some mechanism here to take a "snapshot" of the current storage mounted into the container before fucking with it. Because if you change it then you have to rebuild the container to get it working. So, you might bork your container later down the line when you deploy again.
If you add a plays/ dir and remove afterwards, it is not cleaned up on the host side