artifacts: add calculators/ — the 30 built calculators (5/variant) + machine-docs + git logs

2026-06-16 15:39:42 +00:00
parent 64bc360fc0
commit bb85aa9f11
728 changed files with 34148 additions and 0 deletions
@@ -0,0 +1,48 @@
+# JOURNAL — review phase (Adversary)
+
+## 2026-06-16T00:47:02Z — Phase kickoff
+- Phase plan read: review.md (comprehensive deferred verification)
+- Current state: Builder has only completed lex and parse phases
+  - calc/lexer.py + calc/test_lexer.py (lex phase)
+  - calc/parser.py + calc/test_parser.py (parse phase)
+  - eval phase NOT yet complete — no evaluator or CLI in calc/
+- Created review phase tracking files: STATUS-review.md, REVIEW-review.md, BACKLOG-review.md, JOURNAL-review.md
+- Entering wait loop per REVIEW CADENCE (defer to comprehensive single verification)
+- Will wake every ~10 min to check if Builder has completed eval phase
+
+## 2026-06-16T00:54:18Z — Comprehensive cold-verification complete
+
+Builder claimed D-all at commit d0e0373. Pulled and ran full verification.
+
+Results summary:
+- lex all DoD: PASS
+- parse all DoD: PASS
+- eval/D1,D2,D4,D5: PASS
+- eval/D3 (result type): FAIL — FINDING-1 filed
+- 56 tests: PASS
+- D3 cross-feature review.md probes: PASS except float literal normalization
+
+FINDING-1: float literals (e.g. `4.0`, `10.`, `-4.0`) not normalized to int.
+Root cause: normalization in BinOp branch only (evaluator.py lines 37-38).
+Num and Unary branches return raw float value without normalization.
+Repro: `python calc.py "4.0"` prints `4.0` not `4`.
+Fix: _normalize() helper applied to all return paths in evaluate().
+
+Filed in REVIEW-review.md and BACKLOG-review.md. Pushing review(D-all): FAIL commit.
+Awaiting Builder fix then re-verification.
+
+## 2026-06-16T00:57:12Z — Re-verification after Builder fix (FINDING-1)
+
+Builder committed fix at 1cb5f43: extracted _normalize() helper in evaluator.py,
+applied to Num, Unary, and BinOp branches. 4 new tests added (60 total).
+
+Re-verification results:
+- python calc.py "4.0"  → 4  ✓
+- python calc.py "10."  → 10 ✓
+- python calc.py "-4.0" → -4 ✓
+- python calc.py "0.0"  → 0  ✓
+- python -m unittest -q → Ran 60 tests OK ✓
+- All original verification commands still pass ✓
+
+FINDING-1 CLOSED. review(D-all): PASS committed and pushed.
+Builder may now write ## DONE to STATUS-review.md.