fix: attribute weekly CVEs to PR image diff
This commit is contained in:
@@ -746,6 +746,41 @@ volumes:
|
||||
def test_no_change_yields_no_windows(self):
|
||||
self.assertEqual(self._windows(old=self.NEW, new=self.NEW), [])
|
||||
|
||||
def test_lasuite_docs_pr_does_not_claim_preexisting_valkey_upgrade(self):
|
||||
base = """services:
|
||||
app:
|
||||
image: lasuite/impress-frontend:v6.0.4
|
||||
yhub-valkey:
|
||||
image: valkey/valkey:9.1.3-alpine
|
||||
docspec:
|
||||
image: ghcr.io/docspecio/api:3.0.2
|
||||
"""
|
||||
head = base.replace("ghcr.io/docspecio/api:3.0.2", "ghcr.io/docspec/api:1.21.4")
|
||||
windows = self._windows(old=base, new=head)
|
||||
self.assertEqual(windows, [("api", "3.0.2", "1.21.4")])
|
||||
self.assertNotIn("valkey", [name for name, _, _ in windows])
|
||||
|
||||
captured = {}
|
||||
|
||||
def fake_scan(recipe, v_from, v_to, registry, images):
|
||||
captured.update(from_version=v_from, to_version=v_to, images=images)
|
||||
return {"recipe": recipe, "from": v_from, "to": v_to,
|
||||
"count_known": True, "cve_count_fixed": 0, "cves": {}, "sources": [],
|
||||
"fixed_by_this_upgrade": [], "unclassified": [], "registry_urls": 0,
|
||||
"sources_failed": [], "sources_benign": [], "windows": {},
|
||||
"classified_by": {}}
|
||||
|
||||
with unittest.mock.patch.object(A, "windows_from_compose",
|
||||
return_value=(windows, "pinned base", False)), \
|
||||
unittest.mock.patch.object(A, "scan", fake_scan), \
|
||||
unittest.mock.patch.object(sys, "argv", ["advisory-scan.py", "lasuite-docs",
|
||||
"--compose-from", "base", "--compose-to", "head"]), \
|
||||
unittest.mock.patch.object(sys, "stdout", io.StringIO()), \
|
||||
unittest.mock.patch.object(sys, "stderr", io.StringIO()):
|
||||
A.main()
|
||||
self.assertIsNone(captured["from_version"])
|
||||
self.assertEqual(captured["images"], windows)
|
||||
|
||||
def test_templated_tags_are_skipped(self):
|
||||
new = self.NEW.replace('ghcr.io/plausible/community-edition:v3.2.1', 'ghost:${IMAGE_VERSION}')
|
||||
self.assertNotIn("ghost", [n for n, _, _ in self._windows(new=new)])
|
||||
|
||||
Reference in New Issue
Block a user