change(cleanup): reap dev deploys at start+end of /upgrade-all instead of a timer
Per operator: drop the hourly cc-ci-reap-dev-deploys systemd timer; instead run the dev-* reaper at the START (Step 0, alongside the orphan sweep) and END (new step 4b) of each /upgrade-all run, with THRESHOLD=0 (the run is quiescent then, so clear all dev-* unconditionally). The reaper keeps its safe default (4h) for ad-hoc use. Step-2b mandatory teardown is unchanged (primary mechanism); this is the backstop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
23bba98be4
commit
c60fc6d056
@@ -39,6 +39,14 @@ It is idempotent (a no-op when the host is already clean) and prints what it rem
|
||||
surviving Swarm services (which should be infra + `warm-*` only — eyeball that before continuing). If
|
||||
anything legitimate looks at risk, stop and investigate rather than proceeding.
|
||||
|
||||
Then **reap any leftover step-2b dev deploys** from a prior run (the `dev-*` stacks `/recipe-upgrade`
|
||||
step 2b creates to debug an upgrade with live logs). The full sweep above already removes them, but run
|
||||
the dedicated reaper too so the start/end cleanup is explicit and symmetric (`THRESHOLD=0` = clear ALL
|
||||
`dev-*`, since the run is quiescent now):
|
||||
```
|
||||
ssh cc-ci 'THRESHOLD=0 bash -s' < /srv/cc-ci/.claude/skills/upgrade-all/reap-dev-deploys.sh
|
||||
```
|
||||
|
||||
## 1. Build the candidate list
|
||||
Enrolled recipes = the cc-ci `tests/<recipe>/` dirs (same set `ci-test-review` sweeps):
|
||||
```
|
||||
@@ -132,6 +140,15 @@ with `/recipe-upgrade <recipe> --with-tests` to also get a verified test-update
|
||||
Parse each final `RESULT:` line into SUCCESS / SUCCESS-PENDING-TESTS / FAILED / SKIPPED (default mode
|
||||
won't emit `SUCCESS+TESTPR`). A subagent that emitted no `RESULT:` line → `FAILED — no result emitted`.
|
||||
|
||||
## 4b. Reap dev deploys (END of run)
|
||||
Every `/recipe-upgrade` subagent is required to tear down its own step-2b `dev-<recipe>` deploy, but
|
||||
once ALL recipes are done, reap any that leaked (a crashed/killed subagent) — the symmetric end-of-run
|
||||
cleanup to Step 0. The run is quiescent here, so clear ALL `dev-*` unconditionally (`THRESHOLD=0`):
|
||||
```
|
||||
ssh cc-ci 'THRESHOLD=0 bash -s' < /srv/cc-ci/.claude/skills/upgrade-all/reap-dev-deploys.sh
|
||||
```
|
||||
(Scoped to `dev-*` only — never touches the recipe PRs, CI per-run stacks, `warm-*`, or infra.)
|
||||
|
||||
## 5. Write + print the summary
|
||||
Write `/srv/cc-ci/.cc-ci-logs/upgrades/upgrade-all-<YYYY-MM-DD>.md` and print it, **leading with the
|
||||
PR list** (the actionable output):
|
||||
|
||||
Reference in New Issue
Block a user