fix(bridge): ignore pre-start trigger comments
Some checks failed
continuous-integration/drone/push Build is failing
Some checks failed
continuous-integration/drone/push Build is failing
This commit is contained in:
@ -343,3 +343,52 @@ Takeaways:
|
||||
- There is also likely a separate trigger dedupe problem: one `!testme` comment spawned runs `568`, `569`,
|
||||
and `570`. I did not broaden into a D1 investigation in this loop step because cfold M2 is already
|
||||
hard-blocked by Ghost's repeated upgrade failures, but the evidence is now recorded.
|
||||
|
||||
## 2026-06-13 — Root-caused Ghost triple-trigger replay; bridge fix authored with unit coverage
|
||||
|
||||
Pulled the Adversary's latest cfold audit (`review(cfold)` `ddefc96`). It was not an M2 verdict or a
|
||||
finding; it confirmed the sweep is still unclaimable while teardown remains clean (`live_pr_apps=0`).
|
||||
|
||||
I then closed out the duplicate-run side observation from the Ghost PR #3 retrigger.
|
||||
|
||||
Evidence:
|
||||
|
||||
```bash
|
||||
$ ssh cc-ci 'docker logs --since "2026-06-13T00:07:30" --until "2026-06-13T00:08:30" c54c433972ac 2>&1'
|
||||
[poll] triggered build 568 for ghost@720faa0b (PR #3, comment 14029) by autonomic-bot
|
||||
[poll] triggered build 569 for ghost@720faa0b (PR #3, comment 14032) by autonomic-bot
|
||||
[poll] triggered build 570 for ghost@720faa0b (PR #3, comment 14497) by autonomic-bot
|
||||
|
||||
$ ssh cc-ci 'docker service ps ccci-bridge_app --no-trunc'
|
||||
# single running replica only; no restart near the incident
|
||||
|
||||
$ ssh cc-ci 'docker ps --format "{{.ID}} {{.Names}} {{.Status}}" | grep ccci-bridge || true'
|
||||
c54c433972ac ccci-bridge_app.1.u5msezm603izeyf7kizqxq97j Up 22 hours
|
||||
```
|
||||
|
||||
Conclusion: this was NOT one comment id deduped incorrectly inside a single process. It was the poller
|
||||
correctly treating THREE distinct comment ids as unseen after PR #3 was reopened:
|
||||
|
||||
- `14029` and `14032` were historical `!testme` comments from when PR #3 had been open earlier.
|
||||
- PR #3 was closed when the current bridge process started, so those comments were not covered by the
|
||||
startup pass that marks pre-existing comments seen.
|
||||
- When PR #3 was reopened, the poller saw those old comments for the first time and replayed them, then
|
||||
also processed the fresh comment `14497`.
|
||||
|
||||
Repo fix authored:
|
||||
|
||||
- `bridge/bridge.py`: added `_PROCESS_STARTED_AT` and `_is_preexisting_comment()` so the poller now marks
|
||||
any trigger comment older than the current bridge process as already-seen, even if the PR was closed at
|
||||
startup and only becomes visible later via reopen.
|
||||
- `tests/unit/test_bridge_trigger.py`: added focused tests for pre-start vs post-start comment handling.
|
||||
|
||||
Verification:
|
||||
|
||||
```bash
|
||||
$ nix shell nixpkgs#python311Packages.pytest -c pytest tests/unit/test_bridge_trigger.py -q
|
||||
.......... [100%]
|
||||
10 passed in 0.04s
|
||||
```
|
||||
|
||||
This fix addresses the replay hole exposed during cfold's Ghost retrigger. It does not change the cfold
|
||||
bottom line: Ghost's upgrade tier remains the lone M2 blocker, while custom discovery continues to pass.
|
||||
|
||||
Reference in New Issue
Block a user