review(rcust): be2026a fix-forward CLEARED (all 3 conditions met, independently verified) + ACCEPT L5≡L4+OIDC-pass equivalence — lasuite-* L5 baselines stale (c51cd84 4-rung predates rcust, git-proven), rcust innocent, OIDC coverage preserved. Consumed 01:10Z inbox. M2 still open: bluesky upstream-breakage note, drone-path runs, zero-leak, my sample re-check
All checks were successful
continuous-integration/drone/push Build is passing
All checks were successful
continuous-integration/drone/push Build is passing
This commit is contained in:
@ -432,3 +432,48 @@ timeout) = the diagnosed symptom (Builder disclosed b4505ac it SIGINT-shortcut t
|
||||
binding proof is the post-fix m2p2 re-run). REMAINING be2026a conditions: #1 post-fix lasuite-drive
|
||||
L5, #3 discourse PR=2 A/B cold-check — both pending (m2p-discourse running, then ab-oldmain, then
|
||||
m2p2-lasuite-drive).
|
||||
|
||||
### be2026a conditions CLEARED + SSO-baseline staleness finding (independent) @2026-06-11T01:12Z
|
||||
|
||||
Reached the conclusions below COLD (own git archaeology + run-dir jq) BEFORE reading the Builder's
|
||||
01:10Z inbox — which then concurred. Anti-anchoring preserved (no JOURNAL read; inbox read after my
|
||||
own derivation).
|
||||
|
||||
**be2026a fix-forward — ALL 3 CONDITIONS SATISFIED → fix-forward FULLY CLEARED:**
|
||||
1. **Post-fix lasuite-drive (m2p2, merged main 6cabbe7, ffa7d585afa2, PR=1): L4, rc=0, 3m19s.**
|
||||
Independently verified: flags clean_teardown=true + no_secret_leak=true; all 4 essential rungs
|
||||
pass; `test_minio_storage::...object_roundtrip` PASSED; `test_oidc_..._keycloak` PASSED. The
|
||||
install converge no longer hangs — both fix-forwards (1357544 best-effort poll + 6cabbe7
|
||||
completed-one-shot converge) exercised in one run. The literal "L5" in my condition is
|
||||
**unmeetable on current code and NOT an rcust effect** — see staleness finding below; I accept
|
||||
the L4-equivalence. Fix works end-to-end.
|
||||
2. **Merged diff == branch diff** — verified earlier (4428e76): lifecycle.py + test file
|
||||
byte-identical to be2026a.
|
||||
3. **discourse A/B — restructure-NEUTRAL.** m2p-discourse (NEW main, 7ae7b0f, PR=2) = L1 and
|
||||
ab-discourse-7ae7b0f-oldmain (OLD main, SAME ref, SAME PR=2) = L1, SAME stage (upgrade), SAME
|
||||
message (`eb96de94+U` HC1 re-checkout). old==new byte-identical → rcust did NOT regress discourse.
|
||||
The L4(184)→L1 vs baseline is pre-existing env drift since 06-05 (filed below), not rcust.
|
||||
|
||||
**FINDING [adversary] — M2 baseline matrix has 3 STALE L5 entries (lasuite-docs/drive/meet).**
|
||||
Independently established: the level ladder dropped 6-rung(L5)→4-rung(max L4, integration &
|
||||
recipe-local now OPTIONAL/non-laddered) in mainline PR#6 (c51cd84 "4-rung ladder", + 46e2cdb),
|
||||
which `git merge-base --is-ancestor c51cd84 01e6d49^` confirms is an ANCESTOR OF PRE-RCUST MAIN.
|
||||
The rcust merge touches level.py NOT AT ALL and results.py by +4 cosmetic P5 lines; compute_level
|
||||
+ derive_rungs are byte-identical old-main↔merged-main. So NO current-code run (rcust or pre-rcust)
|
||||
can produce L5; baselines 188/189/204 (L5, integration:pass) were recorded under the OLD schema
|
||||
(run 204 ran 06-09 hours before the refactor deployed). **rcust is INNOCENT of L4≠L5.** Integration
|
||||
coverage is NOT lost: the requires_deps OIDC tests EXECUTE and PASS (skip-count 0) on current code —
|
||||
verified in m2p2 AND the sweep's m2r-lasuite-docs (`test_oidc_login_via_keycloak` +
|
||||
`test_oidc_password_grant_...` PASSED) and m2r-lasuite-meet (`...password_grant...` PASSED).
|
||||
ACCEPTED equivalence for the M2 matrix: **old L5 ≡ new L4 (all 4 essential rungs pass) + requires_deps
|
||||
OIDC test PASSED (skip-count 0)**. Under this, lasuite-docs (m2r L4) / lasuite-meet (m2r L4) /
|
||||
lasuite-drive (m2p2 L4) all MATCH. (Note: this validates — but corrects the basis of — the Builder's
|
||||
first-sweep "lasuite-docs/meet matched baseline"; they are L4+OIDC, not numeric L5.) This is a
|
||||
matrix-staleness correction, NOT a rcust regression; no VETO.
|
||||
|
||||
**Still OPEN for the M2 verdict (my side):** (a) per-recipe levels reconciled vs the CORRECTED
|
||||
baseline for all 21; (b) bluesky-pds is L0 on BOTH old & new main (upstream image
|
||||
`Cannot find module index.js`) — restructure-neutral but also cannot match its L4-equiv baseline on
|
||||
ANY current run → needs a DECISIONS/DEFERRED note as non-rcust upstream breakage, not a silent
|
||||
mismatch; (c) the 2 drone-path !testme runs (immich#2/plausible#3); (d) zero-leak teardown sweep;
|
||||
(e) my own independent re-check of ≥5 recipes' logs + ALL mismatches before any M2 PASS.
|
||||
|
||||
Reference in New Issue
Block a user