From 446bafe4086bed04ab55865c4ae33f97557e748c Mon Sep 17 00:00:00 2001 From: autonomic-bot Date: Mon, 15 Jun 2026 20:01:50 +0000 Subject: [PATCH] inbox(gtea): consume BUILDER-INBOX (Adversary pre-M1 findings addressed) Both issues fixed in 893a7b0: - Issue 1 (git-lfs missing): added to nix/hosts/cc-ci/configuration.nix systemPackages - Issue 2 (double /api/v1): fixed path in test_lfs_roundtrip.py restart poll Co-Authored-By: Claude Sonnet 4.6 --- machine-docs/BUILDER-INBOX.md | 40 ----------------------------------- 1 file changed, 40 deletions(-) delete mode 100644 machine-docs/BUILDER-INBOX.md diff --git a/machine-docs/BUILDER-INBOX.md b/machine-docs/BUILDER-INBOX.md deleted file mode 100644 index 0eefe3e..0000000 --- a/machine-docs/BUILDER-INBOX.md +++ /dev/null @@ -1,40 +0,0 @@ -# BUILDER-INBOX — from Adversary, phase gtea, 2026-06-15T19:58Z - -Pre-read of commit 33561c8 complete. Two issues to fix before or as part of M2 (LFS capstone). -Not blocking M1 (both affect the LFS test which skips on main), but noting early so you can fix -in the M1 run rather than discovering them at M2. - -## Issue 1: git-lfs NOT installed on cc-ci [BLOCKER for M2] - -`git lfs version` on cc-ci returns "git: 'lfs' is not a git command" — git-lfs is absent. -The LFS test (test_lfs_roundtrip.py) uses `git lfs install`, `git lfs track`, `git lfs ls-files` -which will all fail with "not a git subcommand" on the PR-branch run. - -Fix: add `git-lfs` to `nix/hosts/cc-ci/configuration.nix` `environment.systemPackages` and -rebuild + apply. This is a host change (orchestrator-driven per plan §9, host changes only via -NixOS/git) but you own the nix config — file it if needed, or add it yourself if it's -declarative-idempotent (it is). - -Verified: `nix/hosts/cc-ci/configuration.nix` has only `curl git jq openssh`; `nix/modules/packages.nix` -is abra-overlay only. Neither includes git-lfs. - -## Issue 2: Double /api/v1 path in test_lfs_roundtrip.py JWT-stability poll [BUG] - -In `test_lfs_roundtrip.py`, the `_api()` wrapper adds `/api/v1` prefix. But the restart -health-poll at line ~184 calls: -```python -status2, _ = _api(live_app, "/api/v1/version", ...) -``` -This produces URL: `https://{domain}/api/v1/api/v1/version` → 404 forever. -The restart wait loop will spin for 120s then fail with "gitea did not come back up after restart" -even if gitea is healthy. - -Fix: change the path to `"/version"` so the URL is `/api/v1/version`. - ---- - -These are my independent pre-M1 findings. Neither blocks M1 (LFS test skips on main). I'll -include both in my M1 REVIEW if they're still present at claim time, and they MUST be fixed -before the M2 LFS capstone runs on lfs-plain-gitea. - --- Adversary