feat(cfold): canonicalize custom test layout
Some checks failed
continuous-integration/drone/push Build is failing
Some checks failed
continuous-integration/drone/push Build is failing
This commit is contained in:
23
tests/cryptpad/custom/test_health_check.py
Normal file
23
tests/cryptpad/custom/test_health_check.py
Normal file
@ -0,0 +1,23 @@
|
||||
"""cryptpad — parity port of recipe-maintainer's health_check.py (Phase 2 P2).
|
||||
|
||||
SOURCE: references/recipe-maintainer/recipe-info/cryptpad/tests/health_check.py
|
||||
|
||||
The original asserted HTTP 200 from `https://cryptpad.<DOMAIN_SUFFIX>/`. The cc-ci port preserves
|
||||
the assertion shape (200 from the served root) adapted to the ephemeral per-run domain. Runs in
|
||||
the custom tier against the shared post-install live deployment.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "..", "runner"))
|
||||
from harness import http as harness_http # noqa: E402
|
||||
|
||||
|
||||
def test_cryptpad_returns_200(live_app):
|
||||
"""Parity with recipe-info/cryptpad/tests/health_check.py: HTTP 200 from root."""
|
||||
url = f"https://{live_app}/"
|
||||
status, _ = harness_http.retry_http_get(url, expect_status=200, max_wait=60, interval=3)
|
||||
assert status == 200, f"cryptpad at {url} returned HTTP {status} (expected 200)"
|
||||
182
tests/cryptpad/custom/test_pad_content_roundtrip.py
Normal file
182
tests/cryptpad/custom/test_pad_content_roundtrip.py
Normal file
@ -0,0 +1,182 @@
|
||||
"""cryptpad — §4.3 create-an-object + read-it-back (Phase 2 P3 + P6); resolves F2-9.
|
||||
|
||||
CryptPad is end-to-end client-side encrypted: the server only ever stores ciphertext, and the
|
||||
decryption key lives in the URL fragment (`#/2/pad/edit/<key>/`). So "create a pad, confirm it
|
||||
persists" cannot be done with bare curl (plan §4.3 note) — it must be a real browser flow. This test
|
||||
proves genuine persistence of decrypted content across a FRESH browser session:
|
||||
|
||||
1. Open `/pad/` in a browser; CryptPad auto-creates a new anonymous pad and writes the edit URL
|
||||
(fragment-keyed) into the address bar. Capture that full URL.
|
||||
2. Type a unique marker into the CKEditor rich-text body (nested sandbox iframe).
|
||||
3. Wait for CryptPad to sync the encrypted update to the server ("Saved").
|
||||
4. Open a **brand-new browser context** (no shared localStorage/cookies — a different "session")
|
||||
and navigate to the captured pad URL.
|
||||
5. Assert the unique marker is present in the re-decrypted pad body.
|
||||
|
||||
Step 4's fresh context is the real proof: the only thing carried over is the URL (incl. its
|
||||
fragment key), so a successful read-back means the content was persisted server-side (encrypted) and
|
||||
correctly decrypted by a new client — not merely cached locally. This is the §4.3 create-and-read-back
|
||||
floor for CryptPad, not a health/SPA-render stand-in.
|
||||
|
||||
Empirically mapped against the recipe under test (CryptPad 2026.2.0): the editor lives in a deeply
|
||||
nested frame `…/pad/ckeditor-inner.html` (top page → `#sbox-iframe` on the sandbox domain → CKEditor
|
||||
frame); first init compiles LESS (~15s on a cold cache), so the frame hunt and hash wait are patient.
|
||||
Transient `net::ERR_NETWORK_CHANGED` is handled by the shared `goto_with_retry` (F2-3).
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import contextlib
|
||||
import os
|
||||
import sys
|
||||
import uuid
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "..", "runner"))
|
||||
from harness import browser as harness_browser # noqa: E402
|
||||
|
||||
|
||||
def _open_pad(ctx, url):
|
||||
"""Open `url`, wait for full init, and return (page, pad_edit_url). The pad URL is the address
|
||||
bar once CryptPad has created/loaded the fragment-keyed pad (`#/2/pad/edit/<key>/`)."""
|
||||
page = ctx.new_page()
|
||||
harness_browser.goto_with_retry(
|
||||
page,
|
||||
url,
|
||||
accept_statuses=(200,),
|
||||
goto_timeout_ms=60_000,
|
||||
wait_until="load",
|
||||
deadline_seconds=150,
|
||||
)
|
||||
pad_url = url
|
||||
# Up to ~240s for CryptPad to create/load the fragment-keyed pad. A FRESH per-run deploy is
|
||||
# cold (server datastore + LESS compile + first-ever websocket), and `/` → 200 (the recipe
|
||||
# health gate) can be reached before CryptPad's API is ready to mint a pad — so be patient and,
|
||||
# if no pad after ~80s, reload once to unstick a load that stalled before pad creation.
|
||||
for i in range(120):
|
||||
page.wait_for_timeout(2000)
|
||||
if "#/2/pad/edit/" in page.url:
|
||||
pad_url = page.url
|
||||
break
|
||||
if i == 40:
|
||||
with contextlib.suppress(Exception): # best-effort unstick
|
||||
harness_browser.goto_with_retry(
|
||||
page,
|
||||
url,
|
||||
accept_statuses=(200,),
|
||||
goto_timeout_ms=60_000,
|
||||
wait_until="load",
|
||||
deadline_seconds=120,
|
||||
)
|
||||
return page, pad_url
|
||||
|
||||
|
||||
def _ckeditor_frame(page, deadline_polls=90, reload_at=22, reload_url=None):
|
||||
"""Return CryptPad's CKEditor content frame (`…/pad/ckeditor-inner.html`), polling for it to
|
||||
attach. It loads after the sandbox iframe + a cold-cache LESS compilation (~15s+), and a FRESH
|
||||
browser context re-downloads/recompiles everything, which under this env's hairpin network can be
|
||||
slow/flaky — so be patient (up to ~deadline_polls*2s) and, halfway, do ONE reload to unstick a
|
||||
load that stalled on a transient net error."""
|
||||
for i in range(deadline_polls):
|
||||
for f in page.frames:
|
||||
if "ckeditor-inner" in f.url:
|
||||
return f
|
||||
if i == reload_at and reload_url is not None:
|
||||
with contextlib.suppress(Exception): # reload is a best-effort unstick
|
||||
harness_browser.goto_with_retry(
|
||||
page,
|
||||
reload_url,
|
||||
accept_statuses=(200,),
|
||||
goto_timeout_ms=60_000,
|
||||
wait_until="load",
|
||||
deadline_seconds=120,
|
||||
)
|
||||
page.wait_for_timeout(2000)
|
||||
return None
|
||||
|
||||
|
||||
def _poll_any_frame_for_text(
|
||||
page, needle, deadline_polls=120, reload_at=(20, 45, 75, 100), reload_url=None
|
||||
):
|
||||
"""Robust read-back (F2-13): poll EVERY frame's body text for `needle`, returning True as soon as
|
||||
it appears. The fresh cold-cache read-back context's deeply-nested CKEditor frame is slow/flaky to
|
||||
*attach* by URL (the prior `_ckeditor_frame` wait timed out on the Adversary's cold run), but the
|
||||
decrypted pad content lands in whichever frame renders it — so we don't require a specific frame,
|
||||
we just watch all of them for the marker. Reload periodically to unstick a stalled cold load.
|
||||
Generous deadline (~deadline_polls*2s) since the fresh context recompiles LESS + re-fetches +
|
||||
decrypts. Returns False if the marker never appears (genuine non-persistence)."""
|
||||
for i in range(deadline_polls):
|
||||
for f in page.frames:
|
||||
try:
|
||||
if needle in (f.locator("body").inner_text(timeout=2000) or ""):
|
||||
return True
|
||||
except Exception: # noqa: BLE001 — frame not ready / detached; keep polling
|
||||
pass
|
||||
if reload_url and i in reload_at:
|
||||
with contextlib.suppress(Exception): # best-effort unstick
|
||||
harness_browser.goto_with_retry(
|
||||
page,
|
||||
reload_url,
|
||||
accept_statuses=(200,),
|
||||
goto_timeout_ms=60_000,
|
||||
wait_until="load",
|
||||
deadline_seconds=120,
|
||||
)
|
||||
page.wait_for_timeout(2000)
|
||||
return False
|
||||
|
||||
|
||||
def _dismiss_store_modal(page):
|
||||
"""Anonymous pads prompt 'store in CryptDrive?'. Dismiss it (DON'T STORE) so it can't intercept
|
||||
editor clicks. Non-fatal if absent."""
|
||||
for f in page.frames:
|
||||
try:
|
||||
btn = f.get_by_text("DON'T STORE", exact=False)
|
||||
if btn.count():
|
||||
btn.first.click(timeout=3000)
|
||||
return
|
||||
except Exception: # noqa: BLE001 — best-effort modal dismissal
|
||||
pass
|
||||
|
||||
|
||||
def test_cryptpad_pad_content_survives_fresh_session(live_app):
|
||||
"""Create a pad, type a unique marker, then read it back from a FRESH browser context via the
|
||||
fragment-keyed URL — proving end-to-end-encrypted content persisted server-side (§4.3)."""
|
||||
from playwright.sync_api import sync_playwright
|
||||
|
||||
marker = f"CCCI-PAD-{uuid.uuid4().hex[:12].upper()}"
|
||||
with sync_playwright() as p:
|
||||
browser = p.chromium.launch(args=["--no-sandbox"])
|
||||
try:
|
||||
# --- session 1: create the pad + write the marker ---
|
||||
ctx1 = browser.new_context(ignore_https_errors=True)
|
||||
page, pad_url = _open_pad(ctx1, f"https://{live_app}/pad/")
|
||||
assert (
|
||||
"#/2/pad/edit/" in pad_url
|
||||
), f"CryptPad did not create a fragment-keyed pad URL; got {pad_url!r}"
|
||||
ck = _ckeditor_frame(page, reload_url=pad_url)
|
||||
assert ck is not None, "CKEditor content frame never attached (pad editor not ready)"
|
||||
_dismiss_store_modal(page)
|
||||
body = ck.locator("body")
|
||||
body.click()
|
||||
page.wait_for_timeout(1000)
|
||||
body.type(marker, delay=40)
|
||||
page.wait_for_timeout(12000) # let CryptPad encrypt + sync the update to the server
|
||||
assert (
|
||||
marker in ck.locator("body").inner_text()
|
||||
), "marker not present in the editor after typing — type did not land"
|
||||
ctx1.close()
|
||||
|
||||
# --- session 2: FRESH context (no shared storage/localStorage) reads the pad back by URL.
|
||||
# Robust read-back (F2-13): poll ALL frames for the marker (don't require the CKEditor
|
||||
# frame to attach — that's the flaky part on a cold fresh context). The marker appearing
|
||||
# in a brand-new session proves the content was persisted server-side (encrypted) and
|
||||
# decrypted from only the URL+fragment key.
|
||||
ctx2 = browser.new_context(ignore_https_errors=True)
|
||||
page2, _ = _open_pad(ctx2, pad_url)
|
||||
found = _poll_any_frame_for_text(page2, marker, reload_url=pad_url)
|
||||
assert found, (
|
||||
f"marker {marker!r} did NOT survive into a fresh session — content not persisted/"
|
||||
"decrypted (polled all frames + reloads to a generous deadline)"
|
||||
)
|
||||
finally:
|
||||
browser.close()
|
||||
80
tests/cryptpad/custom/test_pad_create.py
Normal file
80
tests/cryptpad/custom/test_pad_create.py
Normal file
@ -0,0 +1,80 @@
|
||||
"""cryptpad — recipe-specific Playwright test (Phase 2 P3 + P6).
|
||||
|
||||
CryptPad is end-to-end client-side encrypted (plan §4.3: "client-side-encryption: page is
|
||||
JS-rendered, so use Playwright, not bare curl"). This test exercises CryptPad in a real browser:
|
||||
|
||||
1. Browses to `/`.
|
||||
2. Asserts the page title or content carries CryptPad branding (proves the SPA renders).
|
||||
3. Asserts at least one of CryptPad's canonical asset paths (`/customize/`, `/components/`,
|
||||
`main.js`) is referenced in the rendered DOM (proves the SPA bundle is wired client-side).
|
||||
4. Asserts no JavaScript console errors appeared during the SPA load (proves the JS pipeline
|
||||
initialized without breaking).
|
||||
|
||||
**Deferred (Q3.4 follow-up):** the full "create a pad → type content → reload → read-back"
|
||||
test was attempted in earlier drafts but proved version-fragile across CryptPad releases — the
|
||||
recipe under test (10.6.0+5.7.0) does NOT auto-redirect `/pad/` to a fragment-keyed pad URL, and
|
||||
the precise UI selector for the "new pad" / "rich text" app launcher varies across CryptPad
|
||||
versions. The maximal testable subset (SPA renders + JS bundle loads + no console errors) IS
|
||||
implemented here; the create-and-read-back deeper test is tracked in BACKLOG-2 for a follow-up
|
||||
that pins to a specific CryptPad app-launch contract (Adversary sign-off pending per plan §7.1).
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import os
|
||||
import sys
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "..", "runner"))
|
||||
from harness import browser as harness_browser # noqa: E402
|
||||
|
||||
|
||||
def test_cryptpad_spa_renders_with_no_console_errors(live_app):
|
||||
"""Browse to /; assert CryptPad SPA renders + JS bundle initialized + no console errors."""
|
||||
from playwright.sync_api import sync_playwright
|
||||
|
||||
with sync_playwright() as p:
|
||||
browser = p.chromium.launch(args=["--no-sandbox"])
|
||||
try:
|
||||
ctx = browser.new_context(ignore_https_errors=True)
|
||||
page = ctx.new_page()
|
||||
console_errors: list[str] = []
|
||||
page.on(
|
||||
"console",
|
||||
lambda msg: console_errors.append(msg.text) if msg.type == "error" else None,
|
||||
)
|
||||
url = f"https://{live_app}/"
|
||||
harness_browser.goto_with_retry(
|
||||
page, url, accept_statuses=(200,), goto_timeout_ms=60_000, wait_until="load"
|
||||
)
|
||||
|
||||
# SPA branding present in title or content
|
||||
title = (page.title() or "").lower()
|
||||
body = page.content()
|
||||
blower = body.lower()
|
||||
assert (
|
||||
"cryptpad" in title or "cryptpad" in blower
|
||||
), f"CryptPad SPA does not carry brand. title={title!r}, body excerpt: {body[:200]!r}"
|
||||
|
||||
# Canonical CryptPad asset references in the rendered DOM
|
||||
canonical = ("/customize/", "/components/", "main.js", "/api/broadcast")
|
||||
present = [c for c in canonical if c in body]
|
||||
assert present, (
|
||||
f"rendered DOM references NONE of {canonical} — SPA bundle not wired. "
|
||||
f"Body excerpt: {body[:300]!r}"
|
||||
)
|
||||
|
||||
# CryptPad emits some Sentry/3rd-party console errors as info-level (not error) on
|
||||
# some versions. Filter our list to ONLY message strings that look like real errors
|
||||
# (the page.on filter already kept only msg.type == 'error'). Tolerate up to one
|
||||
# 401/403 (anonymous user) but flag any others.
|
||||
real_errors = [
|
||||
e
|
||||
for e in console_errors
|
||||
if "401" not in e and "403" not in e and "favicon" not in e.lower()
|
||||
]
|
||||
assert not real_errors, (
|
||||
f"CryptPad SPA logged JavaScript console errors during initial load: "
|
||||
f"{real_errors[:5]}"
|
||||
)
|
||||
finally:
|
||||
browser.close()
|
||||
72
tests/cryptpad/custom/test_spa_assets.py
Normal file
72
tests/cryptpad/custom/test_spa_assets.py
Normal file
@ -0,0 +1,72 @@
|
||||
"""cryptpad — recipe-specific functional test (Phase 2 P3, ≥2 beyond parity).
|
||||
|
||||
CryptPad's served SPA at `/` carries distinctive markers — a CryptPad-branded HTML page that
|
||||
loads specific known asset paths (`/customize/main.js` is the canonical entry point on every
|
||||
CryptPad version) and references CryptPad-specific strings (e.g. "CryptPad" in the page title,
|
||||
`/components/` for the SPA's bundled JS deps). A working cryptpad-server emits this; a broken one
|
||||
(SPA build missing, nginx misrouted) emits something else even when /healthz / `/` are 200.
|
||||
|
||||
This test fetches `/` and asserts:
|
||||
1. The HTML contains the string "CryptPad" (case-insensitive) somewhere — page title, branding,
|
||||
or asset references.
|
||||
2. The HTML references at least one of the canonical CryptPad-bundled asset paths
|
||||
(`/customize/`, `/components/`, or `/api/broadcast`) — proves the SPA bundle is bound, not
|
||||
just some empty default page.
|
||||
|
||||
Non-vacuous: an nginx serving an empty default page (or a misconfigured cryptpad-server replaced
|
||||
by a fallback) would 200 the parity test but fail BOTH markers here.
|
||||
|
||||
Runs in the custom tier against the shared post-install deployment.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import os
|
||||
import ssl
|
||||
import sys
|
||||
import urllib.request
|
||||
|
||||
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "..", "runner"))
|
||||
from harness import http as harness_http # noqa: E402
|
||||
|
||||
|
||||
def _get_body(url: str) -> tuple[int, str]:
|
||||
ctx = ssl.create_default_context()
|
||||
ctx.check_hostname = False
|
||||
ctx.verify_mode = ssl.CERT_NONE
|
||||
req = urllib.request.Request(url, method="GET")
|
||||
with urllib.request.urlopen(req, timeout=15, context=ctx) as r:
|
||||
return r.status, r.read().decode(errors="replace")
|
||||
|
||||
|
||||
def test_cryptpad_spa_has_recipe_specific_markers(live_app):
|
||||
"""GET /; assert CryptPad-specific HTML markers (branding + canonical asset paths)."""
|
||||
url = f"https://{live_app}/"
|
||||
|
||||
# Poll for the body in case the SPA's first response is slow to assemble
|
||||
def _ready():
|
||||
try:
|
||||
status, body = _get_body(url)
|
||||
except Exception: # noqa: BLE001
|
||||
return None
|
||||
if status != 200:
|
||||
return None
|
||||
return body
|
||||
|
||||
body = harness_http.assert_converges(
|
||||
_ready, f"GET {url} returns 200 with body", max_wait=60, interval=3
|
||||
)
|
||||
|
||||
lower = body.lower()
|
||||
# Marker 1: the "CryptPad" branding string must be present somewhere
|
||||
assert "cryptpad" in lower, (
|
||||
f"GET {url} HTML does not contain 'CryptPad' branding — the SPA may be misrouted "
|
||||
f"or a placeholder is being served. Body excerpt: {body[:200]!r}"
|
||||
)
|
||||
# Marker 2: at least one of CryptPad's canonical asset path references must appear
|
||||
canonical_paths = ("/customize/", "/components/", "/api/broadcast", "main.js")
|
||||
present = [p for p in canonical_paths if p in body]
|
||||
assert present, (
|
||||
f"GET {url} HTML references NONE of {canonical_paths} — the CryptPad SPA bundle is "
|
||||
f"not bound. Body excerpt: {body[:300]!r}"
|
||||
)
|
||||
Reference in New Issue
Block a user