recipe-maintainers/cc-ci
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review(drone): ADV-drone-03 CRITICAL — DG4.1 always fires with cold dep (run exits 1)
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse Source 
deps.py module docstring says "Dep deploys DO count toward DG4.1; expected = 1 + n_cold_deps"
but deploy_deps passes _count_deploy=False, so deps never increment the counter. With gitea
as cold dep: actual=1, expected=2 → DG4.1 fires → overall=1 → CI FAIL even when all tiers
pass and level=5.

Confirmed in Builder's run 4 (/tmp/drone-m1-run4.log): install+upgrade+custom green, L5,
but deploy-count 1 != 2 (DG4.1 violation). Run exits 1.

Fix: remove _count_deploy=False from deps.py:deploy_deps (one line). Deps SHOULD count.
ADV-drone-02 also filed (dep orphan on SSO-enrichment failure). Both must be fixed before
M1 can be claimed. BUILDER-INBOX updated with priority order.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
autonomic-bot
2026-06-11 22:04:27 +00:00
parent 0aa46dbe72
commit 52866602e7
3 changed files with 100 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
machine-docs/REVIEW-drone.md
View File

@ -142,6 +142,23 @@ when `deps_state` is empty) or option B (separate deploy from enrichment trackin
**Status:** OPEN — must be fixed before M1 can be claimed.
### ADV-drone-03 — DG4.1 counter mismatch; run always exits 1 with cold dep (CRITICAL)
**Filed:** 2026-06-11T22:15Z — see BACKLOG-drone.md for full details.
`deps.py` module docstring (line 19-20) says "Dep deploys DO count toward DG4.1;
`expected = 1 + deps_deployed_count`." But `deploy_deps` passes `_count_deploy=False` →
dep deploys never increment the counter. With gitea as a cold dep: `actual=1, expected=2`
→ DG4.1 fires → `overall = 1` → CI FAIL, even when all tiers pass and level=5 is reached.
**Confirmed in Builder's run 4 log** (`/tmp/drone-m1-run4.log`):
all tiers green, L5, but `deploy-count 1 != 2 (DG4.1 violation)`.
Fix: remove `_count_deploy=False` from `deploy_deps` (deps SHOULD count per the docstring
and the expected formula). Update the stale comment that contradicts the module docstring.
**Adversary position:** Veto on M1 if not fixed. Run always fails with this bug present.
---
## Standing break-it probes