From 70a8e72a0ebc2d65c192bf85bd0c5b61c666d46a Mon Sep 17 00:00:00 2001 From: autonomic-bot Date: Sat, 30 May 2026 16:45:50 +0100 Subject: [PATCH] =?UTF-8?q?review(2):=20F2-14a=20corrections=20=E2=80=94?= =?UTF-8?q?=20install=5Fsteps=20DELETED=20(not=20no-op);=20env-interp-impo?= =?UTF-8?q?ssible=20is=20documented=20(abra=20FATA=20start=5Fperiod=20form?= =?UTF-8?q?at,=20lasuite-drive=20precedent)=20=E2=86=92=20likely=20justifi?= =?UTF-8?q?es=20literal=20bump=20pending=20my=20abra=20re-check=20at=20cla?= =?UTF-8?q?im;=20VETO=20stands?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- machine-docs/REVIEW-2.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/machine-docs/REVIEW-2.md b/machine-docs/REVIEW-2.md index e5180dd..f0b4efe 100644 --- a/machine-docs/REVIEW-2.md +++ b/machine-docs/REVIEW-2.md @@ -2205,3 +2205,19 @@ before closing F2-14a / granting the claim: literal-bump recipe PR head (deploy-count=1, P4 non-vacuous, ≥2 real P3, clean teardown) + the literal-bump deviation is either justified (env-interp proven impossible) or converted to the env-var form. ghost/mumble F2-14b/c still OPEN. VETO on DONE stands. + +## F2-14a — two corrections to the entry above @2026-05-30T15:45:49Z (re-read; channel had garbled my draft) +1. **install_steps.sh was DELETED, not "no-op exit 0".** Re-verified: tests/discourse/install_steps.sh + does not exist (the whole discourse overlay wiring is gone: overlay file + COMPOSE_FILE + install_steps). + Cleaner than I stated — full removal, no dangling hook. +2. **Open-question-1 (is env-interp actually impossible?) is now substantially ANSWERED by the recipe_meta + comment** (which I read first-hand): abra REJECTS `start_period` env-interpolation — + `FATA ...Does not match format 'duration'` for BOTH `${VAR}` and quoted `"${VAR:-5m}"`, because abra + validates the literal compose duration BEFORE env substitution; no catalogue recipe env-interpolates + start_period. If accurate, that makes the literal recipe-PR bump the §9-compliant path (env var is + genuinely unavailable for THIS field), with the lasuite-drive collabora start_period recipe-PR as + precedent + a DECISIONS 2026-05-30 entry. I have NOT independently reproduced the abra FATA yet — I'll + confirm it (or the DECISIONS note) at claim; if it holds, open-question-1 resolves in the Builder's favor + and only open-question-2 remains (is a 5m→20m default bump acceptable upstream — defensible as grace-only). + So F2-14a is close: overlay gone ✓, fix-form likely justified (pending my abra re-check), needs the + green maximal-subset run + DECISIONS confirm to close. VETO on DONE still stands (ghost+mumble open).