review(1b): W0/RL1 PASS logged; W1 Builder §3 self-review — all blocking invariants hold, no fixes; await Adversary RL2 pass #2

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-27 21:06:57 +01:00
parent 1237d29899
commit 938f312345
3 changed files with 55 additions and 20 deletions

View File

@ -4,19 +4,20 @@ Phase-namespaced backlog. Builder owns `## Build backlog`; Adversary owns `## Ad
## Build backlog
### W0 — Tooling + format (RL1)
- [ ] Add lint tooling to the flake: a `lint` devshell (nixpkgs-fmt, statix, deadnix, ruff,
### W0 — Tooling + format (RL1) — DONE (Adversary PASS @2026-05-27)
- [x] Add lint tooling to the flake: a `lint` devshell (nixpkgs-fmt, statix, deadnix, ruff,
shellcheck, shfmt, yamllint) built from the pinned nixpkgs.
- [ ] Add a `lint` entrypoint script (`scripts/lint.sh`) with check + `--fix` modes; tool configs
- [x] Add a `lint` entrypoint script (`scripts/lint.sh`) with check + `--fix` modes; tool configs
(ruff, yamllint, etc.).
- [ ] Auto-format the codebase (nix + python + shell); commit the mechanical reformat separately.
- [ ] Fix remaining lint findings (statix/deadnix/ruff-lint/shellcheck) without weakening any test.
- [ ] Wire a `lint` stage into `.drone.yml` (push event) so future commits stay clean; verify green
in CI from a clean checkout.
- [x] Auto-format the codebase (nix + python + shell).
- [x] Fix remaining lint findings (statix/deadnix/ruff-lint/shellcheck) without weakening any test.
- [x] Wire a `lint` stage into `.drone.yml` (push event); verified green from a clean checkout
(Adversary cold PASS + break-it probe).
### W1 — Review checklist + fixes (RL2)
- [ ] Run the §3 white-box checklist over the codebase; classify each finding blocking vs advisory.
- [ ] Fix every blocking finding; triage advisory ones to BACKLOG/IDEAS with a one-line rationale.
- [x] Run the §3 white-box checklist (Builder side): all blocking invariants hold (tests-real,
harness-DRY, nix-idempotent, no-footguns, no-secrets, log-redaction); no fix needed; no advisory
to file. Recorded in JOURNAL-1b. Awaiting Adversary's own §3 pass #2 to confirm RL2.
### W2 — Re-verify + document (RL3/RL4)
- [ ] After W0+W1 land, request Adversary cold re-verification of all D1D10 (RL3).