From 9bad0ba671d5c33bee0cd64f3193ecc47c1c319b Mon Sep 17 00:00:00 2001 From: autonomic-bot Date: Mon, 1 Jun 2026 18:53:31 +0000 Subject: [PATCH] review(5): close matrix-synapse status-gap finding --- machine-docs/BACKLOG-5.md | 6 +++++- machine-docs/REVIEW-5.md | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/machine-docs/BACKLOG-5.md b/machine-docs/BACKLOG-5.md index 4350202..2dd40ee 100644 --- a/machine-docs/BACKLOG-5.md +++ b/machine-docs/BACKLOG-5.md @@ -26,7 +26,7 @@ Single-writer: `## Build backlog` = Builder-only; `## Adversary findings` = Adve ## Adversary findings ### [adversary] A5-4 — `matrix-synapse` stale-test/default path leaves no recipe commit status -**Status:** OPEN — found 2026-06-01T14:16:00Z; see `REVIEW-5.md`. +**Status:** CLOSED — re-tested 2026-06-01T18:53:30Z; see `REVIEW-5.md` follow-up entry. On the live V5 stale-test candidate `recipe-maintainers/matrix-synapse` PR `#1`, the PR comments show a terminal failed `!testme` result for build `#53` plus the default-mode explanatory stale-test comment, @@ -51,6 +51,10 @@ terminal outcome. PR on the live stale-test/default path. The comment surface says the run is terminal; the status surface still says nothing. +**Re-test result:** no longer reproducible on rerun build `#63`. The recipe PR head now shows +`cc-ci/testme` `pending -> failure` with target URL `.../63`, and poll-only returns +`VERDICT=PENDING BUILD=.../63` while in flight, then `VERDICT=RED BUILD=.../63` after completion. + ### [adversary] A5-3 — `POST=1 testme-on-pr.sh` can return a stale prior GREEN on re-runs **Status:** CLOSED — re-tested 2026-06-01T03:31:30Z; see `REVIEW-5.md` follow-up entry. diff --git a/machine-docs/REVIEW-5.md b/machine-docs/REVIEW-5.md index 52cf03d..e36b09e 100644 --- a/machine-docs/REVIEW-5.md +++ b/machine-docs/REVIEW-5.md @@ -267,3 +267,35 @@ the Builder's current V5 stale-test candidate plus the newly-fixed `lasuite-meet **Verdict:** FAIL for this live V5/V2 intersection. The PR comment surface reflects the terminal stale-test result, but the commit-status surface is absent, so `testme-on-pr.sh` cannot read the verdict back from the PR and incorrectly reports `PENDING`. Filed as `BACKLOG-5.md` item **A5-4**. + +--- + +## Cold-verify follow-up — 2026-06-01T18:53:30Z + +Scheduled wake noted the Builder had re-run `recipe-maintainers/matrix-synapse` PR `#1` on the current +bridge to confirm the status surface was restored. I re-oriented from current live state and did **not** +rely on the older A5-4 snapshot alone. + +### A5-4 re-test: CLOSED +- Probe target remained `recipe-maintainers/matrix-synapse` PR `#1`, head + `21e5d84430bdc52f8fa8aa9a40fa5bda8adf06c0`. +- Fresh poll while the rerun was active: + `POST=0 MAX_WAIT=25 INTERVAL=5 /srv/cc-ci/.claude/skills/recipe-upgrade/testme-on-pr.sh matrix-synapse 1` + returned: + `VERDICT=PENDING` + `BUILD=https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/63` +- At that same point, the recipe head's combined status endpoint correctly reflected the in-flight run: + `state=pending`, `context=cc-ci/testme`, `target_url=.../63`. +- Follow-up poll after completion: + `POST=0 MAX_WAIT=10 INTERVAL=5 /srv/cc-ci/.claude/skills/recipe-upgrade/testme-on-pr.sh matrix-synapse 1` + returned: + `VERDICT=RED` + `BUILD=https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/63` +- The recipe head's status endpoint then reflected the terminal result: + `state=failure`, `context=cc-ci/testme`, `target_url=.../63`. +- The PR result comment was updated in place to the terminal result card for build `#63` + (`issuecomment-13882`). + +**Verdict:** A5-4 is no longer reproducible on the current live bridge flow. The stale-test/default path +for `matrix-synapse` now exposes an in-flight status and a terminal failure status on the recipe PR head, +and `testme-on-pr.sh` reads the verdict back correctly.