recipe-maintainers/cc-ci
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify to a list of intentionally-skipped rungs
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse Source 
Per operator: drop the gap-sensitivity / cap-intent-clause / stale-detection
machinery. Model is now dead simple — recipe_meta.EXPECTED_NA = {rung: reason}
lists the rungs a recipe intentionally skips; ANY rung skipped (N/A) and not in
that list is unintentional.

results.json: replace the 'na' block + level_cap_intent with
  skips: { intentional: {rung: reason}, unintentional: [rung] }
plus level_cap_rung (which rung capped). Badge/card derive intentional-vs-
unintentional from whether the capping rung is in the intentional list. Skips
still cap the level (never inflate). custom-html-tiny lists all three rungs it
intentionally skips (backup_restore, integration, recipe_local).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
autonomic-bot
2026-06-09 02:36:53 +00:00
parent d733e2c4ca
commit b3ab68a9dd
6 changed files with 105 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
runner/run_recipe_ci.py
View File

@ -1254,27 +1254,18 @@ def main() -> int:
file=sys.stderr,
)
path = results_mod.write_results(data)
intent = data.get("level_cap_intent") or ""
print(
f"results.json written: {path} (level={data['level']}"
f"{' — ' + data['level_cap_reason'] if data['level_cap_reason'] else ''}"
f"{' [' + intent + ']' if intent else ''})",
f"{' — ' + data['level_cap_reason'] if data['level_cap_reason'] else ''})",
flush=True,
)
# Surface the intentional-vs-accidental N/A signal in the CI log (non-blocking, R7): a
# gap-sensitive rung that is N/A but undeclared is a possible coverage hole; a stale
# EXPECTED_NA declares a tier N/A that actually ran.
na = data.get("na", {})
for rung in na.get("gaps", []):
# Surface UNINTENTIONAL skips in the CI log (non-blocking, R7): a rung that was skipped (N/A)
# but is not in the recipe's intentional list — either add the missing coverage or declare it.
for rung in data.get("skips", {}).get("unintentional", []):
print(
f"⚠ coverage: rung '{rung}' is N/A but not declared intentional — add a test or "
f"declare it in tests/{recipe}/recipe_meta.py EXPECTED_NA = {{'{rung}': '<why>'}}.",
flush=True,
)
for rung in na.get("stale_declared", []):
print(
f"⚠ stale EXPECTED_NA: rung '{rung}' is declared N/A but was actually exercised "
f"(status={data['rungs'].get(rung)}) — remove it from recipe_meta.EXPECTED_NA.",
f"⚠ coverage: rung '{rung}' was skipped (N/A) but is not declared intentional — add "
f"the missing test/label, or list it in tests/{recipe}/recipe_meta.py "
f"EXPECTED_NA = {{'{rung}': '<why>'}}.",
flush=True,
)
except Exception as e: # noqa: BLE001 — results assembly is cosmetic; never fail a run on it (R7)
@ -1295,12 +1286,17 @@ def main() -> int:
with open(html_path, "w", encoding="utf-8") as f:
f.write(card_mod.render_card_html(data, screenshot_rel=data.get("screenshot")))
png = card_mod.render_card_png(html_path, os.path.join(run_artifact_dir, "summary.png"))
capped = data.get("level_cap_rung")
sk = data.get("skips", {})
cap_skip = (
"intentional" if capped in (sk.get("intentional") or {})
else "unintentional" if capped in (sk.get("unintentional") or [])
else ""
)
with open(os.path.join(run_artifact_dir, "badge.svg"), "w", encoding="utf-8") as f:
f.write(
card_mod.level_badge_svg(
data["level"],
data.get("level_cap_reason", ""),
data.get("level_cap_intent", ""),
data["level"], data.get("level_cap_reason", ""), cap_skip
)
)
print(