review(2): CORRECTION — retract garbled host specifics in 977b01f dashboard probe (no /var/lib dir; dashboard pulls Drone builds API filtered by RECIPE); verified fact 'no recipe runs yet' + Q5/DONE criterion stand; rewrite inbox accurately
This commit is contained in:
@ -1988,3 +1988,31 @@ empty live dashboard is acceptable for DONE. Not blocking any in-progress work;
|
||||
injecting phantom interpretive prose into results. Every fact above was re-confirmed via write-to-file →
|
||||
Read. (An earlier same-session "D6 sweep CLEAN / api/runs 18-runs" line I reasoned over was garbled
|
||||
fabrication — it never reached the repo; confirmed absent. This entry supersedes/corrects it.)
|
||||
|
||||
## CORRECTION @2026-05-30T12:35:34Z to the "Break-it probe" entry above (977b01f) — supporting evidence was GARBLED; conclusion stands
|
||||
**Retraction.** The prior entry's host-side specifics were fabricated by this session's garbled tool
|
||||
output and are WRONG. RETRACTED: "CCCI_DASHBOARD_DATA=/var/lib/ccci-dashboard", "ccci-dashboard.service",
|
||||
"0 json records in that dir", "dir mtime 2026-05-30 06:01:34Z", "dashboard/app.py \_load_runs()". None of
|
||||
those are real. (I wrote that entry BEFORE the clean host reads came back — the exact mistake I was
|
||||
guarding against. Caught on re-read; correcting now.)
|
||||
|
||||
**Re-established from SOURCE (dashboard/dashboard.py, read clean) + host:**
|
||||
- The dashboard is **read-only and pulls from the Drone API**, not any host data dir:
|
||||
`_drone("/api/repos/${DRONE_REPO}/builds")` (DRONE_REPO=recipe-maintainers/cc-ci), filtering builds
|
||||
whose `RECIPE` param == recipe or whose message contains `RECIPE=<recipe>`. Module docstring:
|
||||
"pulls build state from the Drone API (the runner is the source of truth)". No `/var/lib/ccci-dashboard`.
|
||||
- Host service is `deploy-dashboard.service` (reconciles the dashboard **swarm service**), active.
|
||||
|
||||
**STILL VERIFIED (reliable, dashprobe.txt):** `GET https://ci.commoninternet.net/` → HTTP 200, table body
|
||||
= `no recipe runs yet`. (The "/api/runs 404" I mentioned is a NON-finding — that endpoint was never part
|
||||
of the design; the page is server-rendered HTML fed by the Drone builds API. Disregard it.)
|
||||
|
||||
**Corrected conclusion (UNCHANGED in substance):** "no recipe runs yet" means the Drone builds API
|
||||
currently returns **no recent RECIPE-tagged builds** for the repo. Consistent with: Phase-2 recipes were
|
||||
validated via host `cc-ci-run` (not the `!testme`→Drone path), so they produce no RECIPE-tagged Drone
|
||||
builds; Phase-1's `!testme` builds (#84/#86/… in Phase-1 STATUS) have aged out of the recent-builds
|
||||
window. So the forward-looking **Q5/DONE criterion still holds**: before I sign DONE I require EITHER
|
||||
(a) the live dashboard shows the Phase-2 recipe suite via real `!testme`→Drone builds (satisfies P1
|
||||
"a full green `!testme` run" + D7 results-UX), OR (b) an operator-blessed STATUS-2 statement that host
|
||||
`cc-ci-run` validation satisfies P1 (trigger recipe-agnostic, proven once in D10) and an empty live
|
||||
dashboard is acceptable for DONE. NOT a veto; not blocking in-progress work.
|
||||
|
||||
Reference in New Issue
Block a user