recipe-maintainers/cc-ci
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(2): discourse start_period via literal recipe-PR bump (abra can't env-interpolate start_period)

Browse Source 
abra rejects env-interpolation in healthcheck start_period (FATA 'Does not match
format duration' for both ${VAR} and quoted forms — validates the literal compose
duration before .env substitution). So §9 pt1's env-var route is impossible for
this field; the §9-compliant fix is a LITERAL start_period:20m bump in the
recipe-PR (recipe everyone runs, not a cc-ci overlay; strictly safer). Remove
APP_START_PERIOD from recipe_meta EXTRA_ENV; record the finding in DECISIONS
(ghost E1 must use the same approach); STATUS-2 → new PR head 7a2e0e0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
autonomic-bot
2026-05-30 16:24:45 +01:00
parent 5c2d4c2af3
commit fb20321bd9
2 changed files with 33 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/discourse/recipe_meta.py
View File

@ -9,16 +9,20 @@ HEALTH_OK = (200,)
DEPLOY_TIMEOUT = 2400 # slow Rails cold boot (15-25min); matches the EXTRA_ENV TIMEOUT below
HTTP_TIMEOUT = 1200
# Slow-cold-boot handling via env, NOT a cc-ci compose overlay (plan.md §9 anti-drift guardrail):
# discourse's 15-25min Rails cold boot exceeds the recipe healthcheck's default start_period (5m) +
# grace, so swarm would kill the still-booting app and the deploy never converges. Rather than fork
# the recipe with a compose.*.yml overlay (which drifts from what ships), the recipe-PR
# (recipe-maintainers/discourse#1) parameterizes the app healthcheck as
# `start_period: ${APP_START_PERIOD:-5m}` (default unchanged for real users); cc-ci just sets a larger
# value here. TIMEOUT (abra's internal convergence wait) is raised to outlast the boot.
# Slow-cold-boot handling via a LITERAL recipe-PR start_period bump, NOT a cc-ci compose overlay
# (plan.md §9 anti-drift guardrail). discourse's 15-25min Rails cold boot exceeds the recipe
# healthcheck's default start_period (5m) + grace, so swarm would kill the still-booting app and the
# deploy never converges. §9 pt1 prefers exposing such a value as an env var — but abra REJECTS
# env-interpolation in healthcheck `start_period` (`FATA ...Does not match format 'duration'` for both
# `${VAR}` and quoted `"${VAR:-5m}"`; it validates the literal compose duration before substitution,
# and no catalogue recipe env-interpolates start_period). So the §9-compliant fix is a LITERAL bump in
# the recipe-PR (recipe-maintainers/discourse#1): `start_period: 20m` on the app healthcheck — a change
# to the recipe EVERYONE runs (not a cc-ci fork), and strictly safer (start_period only widens the
# startup grace; a healthy check still marks healthy immediately, so fast hosts are unaffected).
# Precedent: the lasuite-drive collabora start_period recipe-PR. (See DECISIONS.md 2026-05-30.)
# TIMEOUT (abra's internal convergence wait) is raised to outlast the boot.
EXTRA_ENV = {
"TIMEOUT": "2400",
"APP_START_PERIOD": "1200s",
}
# Upgrade tier — N/A (declared NOT-TESTABLE under cc-ci; Adversary §7.1 sign-off GRANTED, REVIEW-2