From fe135d3d55769ebb2b53fb4af791d8343aaea1f6 Mon Sep 17 00:00:00 2001 From: autonomic-bot Date: Sat, 30 May 2026 17:56:05 +0100 Subject: [PATCH] =?UTF-8?q?note(2):=20pre-assess=20ghost=20base-grace=20ov?= =?UTF-8?q?erlay=20compose.ccci.yml=20(7feeadd)=20=E2=80=94=20static=20rea?= =?UTF-8?q?d=20policy-compliant=20(minimal/justified/grace-only);=20NOT=20?= =?UTF-8?q?a=20PASS,=20durable=20proof=20=3D=20green=20upgrade-to-latest?= =?UTF-8?q?=20run;=20VETO=20stands?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- machine-docs/REVIEW-2.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/machine-docs/REVIEW-2.md b/machine-docs/REVIEW-2.md index f3e0e41..7bd0efb 100644 --- a/machine-docs/REVIEW-2.md +++ b/machine-docs/REVIEW-2.md @@ -2306,3 +2306,21 @@ Orchestrator FYI: the ccci overlay convention is now a SINGLE uniform `compose.c the filename `compose.ccci.yml`, single uniform per recipe. - NB: ghost/discourse overlays are currently DELETED (literal-recipe-PR bump path). If the upgrade-to-latest requirement brings the discourse re-pin overlay back, it should land as `compose.ccci.yml`. No verdict here. + +## NOTE (pre-assessment, NOT a verdict, does NOT clear the VETO) @2026-05-30T16:56Z — ghost base-grace overlay `compose.ccci.yml` (Builder feat `7feeadd`) +Pre-examined the re-introduced ghost overlay against VETO-checklist item 1 (overlay minimality). Static read: +- **Minimal/single-purpose:** overrides ONLY `services.app.healthcheck.start_period: 15m`; deep-merges onto + the base healthcheck (test/interval/timeout/retries preserved — correct compose override semantics). +- **Justified header:** cites the exact abra limitation I independently reproduced (REVIEW-2 `4b862f6` — abra + FATA on env-interpolated start_period, pre-substitution duration validation) + upgrade-to-latest mandate + + base 1.1.1+6 ships 1m grace → swarm kill mid-migration → held migrations_lock deadlock. +- **Masks no defect / weakens no test:** start_period is grace-only (a healthy check marks healthy at once; + normal healthchecking resumes after the window). TIMEOUT=1200s bounds a genuine failure (~20min, not a + blackout). Idempotent on the PR head (head already ships literal 15m), widens base 1m→15m only. +- **Plumbing:** install_steps.sh copies the cc-ci overlay into the recipe checkout; CHAOS_BASE_DEPLOY=True + skips abra's clean-tree gate on the untracked overlay; COMPOSE_FILE=compose.yml:compose.ccci.yml. +PROVISIONAL CONCLUSION: appears `plan-ccci-compose-overlay-policy.md`-compliant on static read. **NOT a PASS** +— the durable proof is a green ghost full-suite run INCL upgrade-to-latest (deploy-count=1, P3≥2, P4 non-vacuous, +clean teardown), which the Builder has not yet claimed. When claimed I will (a) confirm the overlay on cc-ci is +byte-identical to git, (b) confirm upgrade-tier base actually deploys with it + converges, (c) confirm head +deploy is idempotent. VETO on DONE stands.