autonomic-bot
47f7cb47c2
Phase 2 lesson from F2-3 (n8n install Playwright flake on net::ERR_NETWORK_CHANGED): every install overlay that does page.goto needs the same try/except PlaywrightError + status retry. Centralize in runner/harness/browser.py::goto_with_retry; apply to ALL install overlays. - runner/harness/browser.py: shared helper. Polls page.goto until status in accept_statuses; catches PlaywrightError (net::ERR_*) as a retryable signal, not a failure. Raises AssertionError with last_status + last_err diagnostic only on deadline expiry. - tests/custom-html/test_install.py: now uses goto_with_retry (200 only, wait_until=load). - tests/custom-html/playwright/test_browser_smoke.py: same. - tests/n8n/test_install.py: replaced inline retry loop with goto_with_retry (200, 304). - tests/keycloak/test_install.py: goto_with_retry for admin console (200, 302, 303; 45s goto). - tests/cryptpad/test_install.py: goto_with_retry (200, 304; 60s goto, wait_until=load). - tests/lasuite-docs/test_install.py: goto_with_retry (200, 301, 302; 60s goto). Cold-verifiable: ssh cc-ci 'RECIPE=custom-html cc-ci-run runner/run_recipe_ci.py' all 5 stages PASS (including the install overlay that flaked in the deps_smoke run), deploy-count=1, head_ref=8a026066==chaos-version=8a026066 (HC1 non-vacuous). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
36 lines
1.7 KiB
Python
36 lines
1.7 KiB
Python
"""custom-html — INSTALL overlay (Phase 1d layering proof, DG4).
|
|
|
|
Demonstrates OVERRIDE + EXTEND-by-composition: this file's presence makes the harness run it INSTEAD
|
|
of the generic install tier (override), and it reuses the generic assertion (`generic.assert_serving`)
|
|
then ADDS a recipe-specific Playwright content check (extend). Assertion-only — the orchestrator has
|
|
already deployed the shared app once (no deploy here, so deploy-count stays 1)."""
|
|
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "runner"))
|
|
from harness import browser as harness_browser, generic # noqa: E402
|
|
|
|
|
|
def test_serving_and_content(live_app, meta):
|
|
# extend-by-composition: reuse the generic "really serving" assertion ...
|
|
generic.assert_serving(live_app, meta)
|
|
# ... then add the recipe-specific assertion: a real browser sees nginx-served HTML (D3).
|
|
from playwright.sync_api import sync_playwright
|
|
|
|
url = f"https://{live_app}/"
|
|
with sync_playwright() as p:
|
|
browser = p.chromium.launch(args=["--no-sandbox"])
|
|
try:
|
|
page = browser.new_context(ignore_https_errors=True).new_page()
|
|
# F2-3-style hardening (centralized in harness.browser.goto_with_retry): retry through
|
|
# transient PlaywrightError (net::ERR_*) and status mismatches.
|
|
resp = harness_browser.goto_with_retry(
|
|
page, url, accept_statuses=(200,), wait_until="load"
|
|
)
|
|
assert resp is not None and resp.status == 200, f"page status {resp and resp.status}"
|
|
body = page.content()
|
|
assert "nginx" in body.lower() or "<html" in body.lower(), "no served HTML content"
|
|
finally:
|
|
browser.close()
|