fd02d9f4b8
All checks were successful
continuous-integration/drone/push Build is passing
harness.meta.HookCtx (frozen): .domain, .base_url, .meta (RecipeMeta), .deps (provisioned dep creds from $CCCI_DEPS_FILE or None), .op (current lifecycle op or None); built via meta.hook_ctx() at each hook call site. All recipe callables now take ctx: EXTRA_ENV(ctx), UPGRADE_EXTRA_ENV(ctx), READY_PROBE(ctx), BACKUP_VERIFY(ctx), SCREENSHOT(page, ctx), ops.py pre_<op>(ctx). Dict-valued EXTRA_ENV/UPGRADE_EXTRA_ENV unchanged (only the callable signature moved). Call sites converted: deploy_app env shaping, perform_upgrade, wait_ready_probes (gains op=), _perform_op BACKUP_VERIFY, screenshot.capture, _run_pre_hook. Legacy signatures fail FAST with a clear migration message: the registry carries hook_params per hook key, enforced at meta.load() (MetaError names the old vs new signature); ops.py pre-op hooks get the same check at the orchestrator call site (meta.check_hook_signature) — no silent TypeError mid-run. Migrated every in-repo user mechanically (17 ops.py files; cryptpad/lasuite-*/ mailu EXTRA_ENV; mumble+lasuite-drive READY_PROBE; ghost/discourse BACKUP_VERIFY) — seeded values, probes and assertions byte-identical (domain -> ctx.domain; keycloak pre_restore's meta arg -> ctx.meta). Unit tests: hook_ctx field contract, ctx.deps from the run deps file, legacy- signature MetaError (READY_PROBE/EXTRA_ENV/SCREENSHOT + pre-op checker), ctx signatures accepted. Docs table regenerated (signature docs in key docs). Verified on cc-ci: cc-ci-run -m pytest tests/unit -q -> 180 passed; scripts/lint.sh -> PASS.
48 lines
1.5 KiB
Python
48 lines
1.5 KiB
Python
"""discourse — pre-op seed hooks (Phase 1e HC3 / Phase 2 P4 backup data-integrity).
|
|
|
|
Discourse persists in postgres (`db` service, user/db=discourse). The recipe's backupbot pre-hook
|
|
pg_dumps that DB, and restore reloads the dump — so real backup data-integrity = seed a `ci_marker`
|
|
row into the discourse DB, back up, mutate, restore, and prove the row survived (the same DB the
|
|
recipe actually backs up). Mirrors the matrix-synapse postgres pattern.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "runner"))
|
|
from harness import lifecycle # noqa: E402
|
|
|
|
|
|
def _psql(domain, sql):
|
|
cmd = (
|
|
"PGPASSWORD=$(cat /run/secrets/db_password) " f'psql -U discourse -d discourse -tAc "{sql}"'
|
|
)
|
|
return lifecycle.exec_in_app(domain, ["sh", "-c", cmd], service="db").strip()
|
|
|
|
|
|
def _seed(domain, value):
|
|
_psql(
|
|
domain,
|
|
"CREATE TABLE IF NOT EXISTS ci_marker(v text); DELETE FROM ci_marker; "
|
|
f"INSERT INTO ci_marker VALUES('{value}');",
|
|
)
|
|
got = _psql(domain, "SELECT v FROM ci_marker;")
|
|
assert got == value, f"seed did not commit (read back {got!r}, expected {value!r})"
|
|
|
|
|
|
def pre_upgrade(ctx):
|
|
_seed(ctx.domain, "upgrade-survives")
|
|
|
|
|
|
def pre_backup(ctx):
|
|
_seed(ctx.domain, "original")
|
|
|
|
|
|
def pre_restore(ctx):
|
|
# diverge from the backup so a successful restore is observable
|
|
_psql(ctx.domain, "DROP TABLE IF EXISTS ci_marker;")
|
|
assert _psql(ctx.domain, "SELECT to_regclass('public.ci_marker');") in (
|
|
"",
|
|
"NULL",
|
|
), "drop did not take"
|