autonomic-bot
47f7cb47c2
Phase 2 lesson from F2-3 (n8n install Playwright flake on net::ERR_NETWORK_CHANGED): every install overlay that does page.goto needs the same try/except PlaywrightError + status retry. Centralize in runner/harness/browser.py::goto_with_retry; apply to ALL install overlays. - runner/harness/browser.py: shared helper. Polls page.goto until status in accept_statuses; catches PlaywrightError (net::ERR_*) as a retryable signal, not a failure. Raises AssertionError with last_status + last_err diagnostic only on deadline expiry. - tests/custom-html/test_install.py: now uses goto_with_retry (200 only, wait_until=load). - tests/custom-html/playwright/test_browser_smoke.py: same. - tests/n8n/test_install.py: replaced inline retry loop with goto_with_retry (200, 304). - tests/keycloak/test_install.py: goto_with_retry for admin console (200, 302, 303; 45s goto). - tests/cryptpad/test_install.py: goto_with_retry (200, 304; 60s goto, wait_until=load). - tests/lasuite-docs/test_install.py: goto_with_retry (200, 301, 302; 60s goto). Cold-verifiable: ssh cc-ci 'RECIPE=custom-html cc-ci-run runner/run_recipe_ci.py' all 5 stages PASS (including the install overlay that flaked in the deps_smoke run), deploy-count=1, head_ref=8a026066==chaos-version=8a026066 (HC1 non-vacuous). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
45 lines
1.9 KiB
Python
45 lines
1.9 KiB
Python
"""lasuite-docs — INSTALL overlay (Phase 1d, DG4): override + extend-by-composition.
|
|
|
|
Reuses the generic "really serving" assertion, then ADDS the recipe-specific checks: the multi-service
|
|
stack serves over real HTTPS through the gateway, and a real browser loads the live Docs frontend (the
|
|
SPA shell). Login is OIDC-gated (no live OIDC provider in CI), so the functional assertion is that the
|
|
frontend SPA is served (unauthenticated landing), not an authenticated flow. Assertion-only on the
|
|
shared deployment."""
|
|
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "runner"))
|
|
from harness import browser as harness_browser, generic, lifecycle # noqa: E402
|
|
|
|
|
|
def test_serving_and_frontend(live_app, meta):
|
|
# extend-by-composition: reuse the generic "really serving" assertion first ...
|
|
generic.assert_serving(live_app, meta)
|
|
|
|
# ... then the recipe-specific assertions.
|
|
status = lifecycle.http_get(live_app, "/")
|
|
assert status in (200, 301, 302), f"expected 2xx/3xx from {live_app}, got {status}"
|
|
|
|
# A real browser loads the live Docs frontend (the SPA shell) over HTTPS.
|
|
from playwright.sync_api import sync_playwright
|
|
|
|
url = f"https://{live_app}/"
|
|
with sync_playwright() as p:
|
|
browser = p.chromium.launch(args=["--no-sandbox"])
|
|
try:
|
|
ctx = browser.new_context(ignore_https_errors=True)
|
|
page = ctx.new_page()
|
|
# F2-3 hardening centralized in harness.browser
|
|
resp = harness_browser.goto_with_retry(
|
|
page, url, accept_statuses=(200, 301, 302), goto_timeout_ms=60_000
|
|
)
|
|
assert resp is not None and resp.status in (
|
|
200,
|
|
301,
|
|
302,
|
|
), f"page status {resp and resp.status}"
|
|
assert "<html" in page.content().lower(), "no HTML served by the frontend"
|
|
finally:
|
|
browser.close()
|