Push builds have been RED on the lint step since ~build 209 from accumulated formatting drift. This is the mechanical cleanup: ruff format + ruff --fix (UP038 isinstance unions, SIM105 contextlib.suppress, UP031 f-strings, SIM115 tempfile context manager), shfmt -i 2 -ci, nixpkgs-fmt/statix/deadnix (merged attrsets, dropped unused lib args), yamllint, and shell quoting fixes in tests/lasuite-docs/setup_custom_tests.sh. No behaviour changes intended; lint: PASS, unit tests: 138 passed.
34 lines
1.8 KiB
Python
34 lines
1.8 KiB
Python
"""ghost — RESTORE overlay (Phase 1e HC3 / Phase 2 P4): data-integrity, assertion-only + additive.
|
|
|
|
ops.pre_restore dropped the ci_marker table (diverge from the backup); the orchestrator restored
|
|
once. This overlay ADDS: the restored DB carries the pre-mutation 'original' marker — proving the
|
|
seeded data actually survived backup→restore, not just that the service came back up.
|
|
|
|
NOTE (expected RED until a recipe-PR lands): the current ghost recipe backs the DB up as a LOGICAL
|
|
mysqldump (`--tab` → SQL files under /var/lib/mysql-files/) but ships **no `backupbot.restore.*`
|
|
hook**, and the actual mysql data volume is NOT itself backupbot-labelled. So a file-level restore
|
|
puts the dump files back on disk but never reimports them into the running MySQL → the dropped marker
|
|
does not return. This is the SAME defect class cc-ci already caught + fixed in immich and
|
|
mattermost-lts (pg_dump backup with no reimport-on-restore). If this test goes RED, the fix is a
|
|
recipe-PR adding a restore post-hook that reimports the dump (terminate/recreate `ghost` DB +
|
|
`mysql ghost < dump` / `mysqlimport`), mirroring the mattermost-lts#1 / immich#1 pattern.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "..", "runner"))
|
|
from harness import lifecycle # noqa: E402
|
|
|
|
|
|
def _mysql(domain, sql):
|
|
cmd = 'MYSQL_PWD="$(cat /run/secrets/db_password)" ' f'mysql -u root -N -s ghost -e "{sql}"'
|
|
return lifecycle.exec_in_app(domain, ["sh", "-c", cmd], service="db").strip()
|
|
|
|
|
|
def test_restore_returns_state(live_app):
|
|
assert _mysql(live_app, "SELECT v FROM ci_marker;") == "original", (
|
|
"restore did not return the pre-mutation ghost MySQL marker (data-integrity failure — "
|
|
"recipe likely lacks a mysqldump-reimport restore hook; see module docstring)"
|
|
)
|