101ffe1964
The postgres major-version migration in the db entrypoint was not safe to
re-run. If the container was killed mid-migration it could crash-loop forever
("mkdir: cannot create directory .../old_data: File exists") or silently initdb
a fresh empty cluster over the live data once PG_VERSION had been moved out of
$PGDATA but before the in-progress marker was written.
Replace the marker file with a state-driven guard keyed on the scratch dirs:
empty old_data/new_data means the run was interrupted before any data moved, so
discard and retry (idempotent); non-empty means data may only live there, so
stop for manual recovery. Bump DB_ENTRYPOINT_VERSION v1->v2 so swarm picks up
the new (immutable) config.
52 lines
1.8 KiB
Bash
52 lines
1.8 KiB
Bash
#!/bin/bash
|
|
|
|
set -e
|
|
|
|
OLDDATA=$PGDATA/old_data
|
|
NEWDATA=$PGDATA/new_data
|
|
|
|
echo "Running as $(id)"
|
|
|
|
# The migration uses $OLDDATA/$NEWDATA as scratch and removes them when it
|
|
# finishes; a leftover *empty* one means a run was interrupted before any data
|
|
# moved (data still intact at $PGDATA) so we clear it and retry, while a
|
|
# *non-empty* one means data may live only there, so we stop for manual recovery.
|
|
for scratch in $OLDDATA $NEWDATA; do
|
|
if [ -d "$scratch" ] && [ -n "$(ls -A "$scratch")" ]; then
|
|
echo "FATAL: $scratch exists and is not empty - a previous migration did not"
|
|
echo "complete and the data may only exist there. manual recovery necessary."
|
|
exit 1
|
|
fi
|
|
done
|
|
rm -rf $OLDDATA $NEWDATA
|
|
|
|
if [ -f $PGDATA/PG_VERSION ]; then
|
|
DATA_VERSION=$(cat $PGDATA/PG_VERSION)
|
|
|
|
if [ -n "$DATA_VERSION" -a "$PG_MAJOR" != "$DATA_VERSION" ]; then
|
|
echo "postgres data version $DATA_VERSION found, but need $PG_MAJOR. Starting migration"
|
|
echo "Installing postgres $DATA_VERSION"
|
|
sed -i "s/$/ $DATA_VERSION/" /etc/apt/sources.list.d/pgdg.list
|
|
apt-get update && apt-get install -y --no-install-recommends \
|
|
postgresql-$DATA_VERSION \
|
|
&& rm -rf /var/lib/apt/lists/*
|
|
echo "shuffling around"
|
|
gosu postgres mkdir $OLDDATA $NEWDATA
|
|
chmod 700 $OLDDATA $NEWDATA
|
|
mv $PGDATA/* $OLDDATA/ || true
|
|
echo "running initdb"
|
|
# abuse entrypoint script for initdb by making server error out
|
|
gosu postgres bash -c "export PGDATA=$NEWDATA ; /usr/local/bin/docker-entrypoint.sh --invalid-arg || true"
|
|
echo "running pg_upgrade"
|
|
cd /tmp
|
|
gosu postgres pg_upgrade --link -b /usr/lib/postgresql/$DATA_VERSION/bin -d $OLDDATA -D $NEWDATA -U $POSTGRES_USER
|
|
cp $OLDDATA/pg_hba.conf $NEWDATA/
|
|
mv $NEWDATA/* $PGDATA
|
|
rm -rf $OLDDATA
|
|
rmdir $NEWDATA
|
|
echo "migration complete"
|
|
fi
|
|
fi
|
|
|
|
/usr/local/bin/docker-entrypoint.sh postgres
|