From a5ce46f2a3bc173d8bc048380d41a35b471eb90e Mon Sep 17 00:00:00 2001 From: autonomic-bot Date: Mon, 10 Aug 2026 16:48:35 +0000 Subject: [PATCH] fix: bump APP_INI_VERSION to v23 (app.ini.tmpl changed in the forgejo removal) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Docker Swarm configs are IMMUTABLE — only labels can be updated. The config is named ${STACK_NAME}_app_ini_${APP_INI_VERSION}, so when app.ini.tmpl's rendered content changes the version suffix MUST be bumped, otherwise abra tries to mutate the existing object and the deploy aborts: FATA failed to update config _app_ini_v22: Error response from daemon: rpc error: code = InvalidArgument desc = only updates to Labels are allowed 'BREAKING CHANGE: remove forgejo' (6a0339d) edited app.ini.tmpl — -{{ if or (eq (env "FORGE") "forgejo") (eq (env "GITEA_LFS_START_SERVER") "true") }} +{{ if (eq (env "GITEA_LFS_START_SERVER") "true") }} — but left APP_INI_VERSION at v22 (unchanged since the LFS commit 357926f), and 3.6.2+1.27.1-rootless shipped that way. Every existing deployment upgrading ACROSS the forgejo removal therefore fails at 'initialising deployment'; reproduced on a live 3.6.1+1.26.2-rootless -> 3.6.2+1.27.1-rootless upgrade. Bumping to v23 makes Swarm create a NEW config object instead of mutating v22. The orphaned v22 object can be pruned after the rollout. Only app.ini.tmpl changed, so DOCKER_SETUP_SH_VERSION and PG_BACKUP_VERSION stay put. Note: cc-ci's upgrade tier did not catch this because it resolved the upgrade base to main-tip, which ALREADY contains the forgejo removal — base and head then render identical app.ini and no config update is attempted. Real deployments upgrade from the last published RELEASE (3.6.1+1.26.2), which is where the break appears. --- abra.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/abra.sh b/abra.sh index 54bf0f3..68fe314 100644 --- a/abra.sh +++ b/abra.sh @@ -1,4 +1,4 @@ -export APP_INI_VERSION=v22 +export APP_INI_VERSION=v23 export DOCKER_SETUP_SH_VERSION=v1 export PG_BACKUP_VERSION=v1