diff --git a/README.md b/README.md index b3f8f53..b7b4e28 100644 --- a/README.md +++ b/README.md @@ -26,4 +26,3 @@ [`abra`]: https://git.coopcloud.tech/coop-cloud/abra [`coop-cloud/traefik`]: https://git.coopcloud.tech/coop-cloud/traefik -p-cloud/traefik diff --git a/abra.sh b/abra.sh index ea81aaa..1a82402 100644 --- a/abra.sh +++ b/abra.sh @@ -1,4 +1,3 @@ export CLICKHOUSE_CONF_VERSION=v2 export CLICKHOUSE_USER_CONF_VERSION=v2 -export DB_ENTRYPOINT_VERSION=v1 -export CLICKHOUSE_ENTRYPOINT_VERSION=v2 +export CLICKHOUSE_ENTRYPOINT_VERSION=v3 diff --git a/compose.yml b/compose.yml index d20575c..bdb4c13 100644 --- a/compose.yml +++ b/compose.yml @@ -12,6 +12,7 @@ services: - BASE_URL=https://$DOMAIN - SECRET_KEY_BASE - DATABASE_URL=postgres://plausible:plausible@${STACK_NAME}_db:5432/plausible + - CLICKHOUSE_DATABASE_URL=http://${STACK_NAME}_plausible_events_db:8123/plausible_events_db - SMTP_HOST_ADDR - MAILER_EMAIL - SMTP_HOST_PORT @@ -32,23 +33,24 @@ services: - "traefik.http.routers.${STACK_NAME}.rule=Host(`${DOMAIN}`${EXTRA_DOMAINS})" - "traefik.http.routers.${STACK_NAME}.entrypoints=web-secure" - "traefik.http.routers.${STACK_NAME}.tls.certresolver=${LETS_ENCRYPT_ENV}" - - coop-cloud.${STACK_NAME}.version=3.0.1+v2.0.0 + - coop-cloud.${STACK_NAME}.version=3.1.0+v2.0.0 db: - image: postgres:13.12 - configs: - - source: db_entrypoint - target: /docker-entrypoint.sh - mode: 0555 - # Custom docker entrypoint to handle major Postgres version upgrades + image: pgautoupgrade/pgautoupgrade:18-alpine volumes: - db-data:/var/lib/postgresql/data - entrypoint: /docker-entrypoint.sh environment: + # pin legacy PGDATA so the existing cluster on the volume is upgraded in place, not re-init'd + - PGDATA=/var/lib/postgresql/data - POSTGRES_USER=plausible - POSTGRES_PASSWORD=plausible - POSTGRES_DB=plausible networks: - internal + healthcheck: + test: ["CMD-SHELL", "pg_isready -U plausible -d plausible"] + interval: 5s + timeout: 5s + retries: 60 deploy: labels: backupbot.backup: "true" @@ -98,10 +100,6 @@ configs: clickhouse-user-config: name: ${STACK_NAME}_clickhouse_user_config_${CLICKHOUSE_USER_CONF_VERSION} file: clickhouse-user-config.xml - db_entrypoint: - name: ${STACK_NAME}_db_entrypoint_${DB_ENTRYPOINT_VERSION} - file: entrypoint.postgres.sh.tmpl - template_driver: golang clickhouse_entrypoint: name: ${STACK_NAME}_clickhouse_entrypoint_${CLICKHOUSE_ENTRYPOINT_VERSION} file: entrypoint.clickhouse.sh diff --git a/entrypoint.clickhouse.sh b/entrypoint.clickhouse.sh index 48f7ac7..8cebd82 100644 --- a/entrypoint.clickhouse.sh +++ b/entrypoint.clickhouse.sh @@ -1,6 +1,14 @@ #!/bin/bash -set -ex +# clickhouse-backup is a backup tool (backupbot pre/post-hooks: `clickhouse-backup create/restore`). +# It is a 22 MB GitHub download (rate-limit / network), which can fail to download, and lead to crash loop and download throttling. +# +# to make the download smoother: +# - cache the binary on the persistent clickhouse data volume (/var/lib/clickhouse) so it is fetched +# at most once and reused on every container restart (no re-download amplification); +# - retry with backoff to ride out transient GitHub failures + +set -e CLICKHOUSE_BACKUP_VERSION=2.4.2 @@ -17,13 +25,33 @@ elif [[ $ARCH =~ "x86_64" ]]; then ARCH="amd64" fi -wget \ - --quiet \ - --continue \ - --no-clobber \ - --output-document=/tmp/clickhouse-backup.tar.gz \ - "https://github.com/AlexAkulov/clickhouse-backup/releases/download/v${CLICKHOUSE_BACKUP_VERSION}/clickhouse-backup-linux-${ARCH}.tar.gz" 2>/dev/null +CACHE_DIR=/var/lib/clickhouse/.ccci-bin +CACHED="${CACHE_DIR}/clickhouse-backup" +BIN=/usr/local/bin/clickhouse-backup +URL="https://github.com/AlexAkulov/clickhouse-backup/releases/download/v${CLICKHOUSE_BACKUP_VERSION}/clickhouse-backup-linux-${ARCH}.tar.gz" -tar -xf /tmp/clickhouse-backup.tar.gz --directory=/usr/local/bin --strip-components=3 +install_clickhouse_backup() { + mkdir -p "$CACHE_DIR" + if [ -x "$CACHED" ]; then + cp -f "$CACHED" "$BIN" + echo "clickhouse-backup: restored from persistent cache ($CACHED)" + return 0 + fi + for attempt in 1 2 3 4 5; do + if wget --continue --output-document=/tmp/clickhouse-backup.tar.gz "$URL" \ + && tar -xf /tmp/clickhouse-backup.tar.gz --directory=/usr/local/bin --strip-components=3; then + cp -f "$BIN" "$CACHED" 2>/dev/null || true + echo "clickhouse-backup: downloaded + cached (attempt ${attempt})" + return 0 + fi + echo "clickhouse-backup: fetch attempt ${attempt} failed; backing off $((attempt * 10))s" >&2 + sleep $((attempt * 10)) + done + echo "clickhouse-backup: fetch FAILED after all retries — aborting; clickhouse-server will NOT start (backup tool is required)" >&2 + return 1 +} -/entrypoint.sh +#if the backup tool cannot be installed after retries, it aborts (set -e) so the deploy fails +install_clickhouse_backup + +exec /entrypoint.sh diff --git a/entrypoint.postgres.sh.tmpl b/entrypoint.postgres.sh.tmpl deleted file mode 100644 index 8ecc4fe..0000000 --- a/entrypoint.postgres.sh.tmpl +++ /dev/null @@ -1,44 +0,0 @@ -#!/bin/bash - -set -e - -MIGRATION_MARKER=$PGDATA/migration_in_progress -OLDDATA=$PGDATA/old_data -NEWDATA=$PGDATA/new_data - -if [ -e $MIGRATION_MARKER ]; then - echo "FATAL: migration was started but did not complete in a previous run. manual recovery necessary" - exit 1 -fi - -if [ -f $PGDATA/PG_VERSION ]; then - DATA_VERSION=$(cat $PGDATA/PG_VERSION) - - if [ -n "$DATA_VERSION" -a "$PG_MAJOR" != "$DATA_VERSION" ]; then - echo "postgres data version $DATA_VERSION found, but need $PG_MAJOR. Starting migration" - echo "Installing postgres $DATA_VERSION" - sed -i "s/$/ $DATA_VERSION/" /etc/apt/sources.list.d/pgdg.list - apt-get update && apt-get install -y --no-install-recommends \ - postgresql-$DATA_VERSION \ - && rm -rf /var/lib/apt/lists/* - echo "shuffling around" - gosu postgres mkdir $OLDDATA $NEWDATA - chmod 700 $OLDDATA $NEWDATA - mv $PGDATA/* $OLDDATA/ || true - touch $MIGRATION_MARKER - echo "running initdb" - # abuse entrypoint script for initdb by making server error out - gosu postgres bash -c "export PGDATA=$NEWDATA ; /usr/local/bin/docker-entrypoint.sh --invalid-arg || true" - echo "running pg_upgrade" - cd /tmp - gosu postgres pg_upgrade --link -b /usr/lib/postgresql/$DATA_VERSION/bin -d $OLDDATA -D $NEWDATA -U $POSTGRES_USER - cp $OLDDATA/pg_hba.conf $NEWDATA/ - mv $NEWDATA/* $PGDATA - rm -rf $OLDDATA - rmdir $NEWDATA - rm $MIGRATION_MARKER - echo "migration complete" - fi -fi - -/usr/local/bin/docker-entrypoint.sh postgres