Also, what can be tested here? Can I mock the JSON to do offline tests?
I've seen rumblings on mocking an actual http call in a unit test for a mock one that returns what ever you want. No rush…
Your function never returns this error. It is just logging it and exiting the program. You should change this to return nil, err. This can then be dealt with by the command itself.
This will never be run because you never return an error, see comment on GetAppsJSON
I am not totally against this approach. I worry about the speed of it but honestly might just say fuck it and use this as our baseline for sorting maps.
Not much to review since most of it is good! Just one note, and a situation where you don't return an error where you should. So gunna label it as requesting a change for that reason but its a one line change 💙
Saw that http://plugins.drone.io/drone-plugins/drone-gitea-release/ can probably sort our release uploading for us.
could use this for our github mirror…
Saw that we can run a CI check that'll lint the commit messages for format:
Looks good but I worry about the effects of doing that…
I think moving to Viper and then doing what makes sense for the situation is the best way forward sindi it seems to support everything. I will move it to Viper and then we can work on the config…