ruangrupa/konfluks
ruangrupa
/
konfluks
2
0
Fork 2
Code Issues 9 Pull Requests Projects Releases Wiki Activity

[video.py] change deletion logic to work when API returns 0 #16

New Issue
Closed
opened 2022-01-09 20:10:27 +00:00 by r · 1 comment
r commented 2022-01-09 20:10:27 +00:00
Member
Copy Link

From: https://git.vvvvvvaria.org/rra/lumbung-video-prototype/issues/4

Currently all the logic of the script is only executed if the API returns any result. See https://git.autonomic.zone/ruangrupa/lumbunglib/src/branch/master/lumbunglib/video.py#L116

If the instance is offline or all videos are made private, none of the logic runs. Thus, videos are also not deleted. This could contradict the intentions when people choose to make all videos private but the posts are not deleted.

From: https://git.vvvvvvaria.org/rra/lumbung-video-prototype/issues/4 Currently all the logic of the script is only executed if the API returns any result. See https://git.autonomic.zone/ruangrupa/lumbunglib/src/branch/master/lumbunglib/video.py#L116 If the instance is offline or all videos are made private, none of the logic runs. Thus, videos are also not deleted. This could contradict the intentions when people choose to make all videos private but the posts are not deleted.
knoflook self-assigned this 2022-03-04 10:15:50 +00:00
aadil added the due date 2022-04-15 2022-04-08 09:18:15 +00:00
knoflook commented 2022-04-11 11:47:22 +00:00
Owner
Copy Link

fixed in bac9bbd7b3

fixed in https://git.autonomic.zone/ruangrupa/lumbunglib/commit/bac9bbd7b3c6d48a41a6692e9d9e5cf08f16e20c
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
new-taxonomy
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
knoflook
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2022-04-15

Dependencies

No dependencies set.

Reference: ruangrupa/konfluks#16
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?