ruangrupa/konfluks
2
0
Fork 2
Code Issues 9 Pull Requests Projects Releases Wiki Activity

feat: sanitize all yaml #28

Merged
knoflook merged 3 commits from knoflook/lumbunglib:master into master 2022-04-12 11:44:35 +00:00
Conversation 6 Commits 3 Files Changed 3
+67 -5
knoflook commented 2022-03-18 12:59:44 +00:00
Owner
Copy Link
Copy Source

closes #6

closes #6
decentral1se reviewed 2022-04-06 07:51:36 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

nice one, happy to try this out! unsure if that regex covers what we need because I don't know regex at all 😆 did see that https://github.com/nexB/saneyaml is a thing but dunno if it is overkill for this task? merge as you see fit i'd say 🚀

nice one, happy to try this out! unsure if that regex covers what we need because I don't know regex at all 😆 did see that https://github.com/nexB/saneyaml is a thing but dunno if it is overkill for this task? merge as you see fit i'd say 🚀
knoflook force-pushed master from 9e846c396c to bac9bbd7b3 2022-04-12 11:41:55 +00:00 Compare
knoflook added 3 commits 2022-04-12 11:43:15 +00:00
feat: sanitize all yaml 2fbc952a72
fix: don't escape some characters cf8b1ff7e9
feed: move to saneyaml a809433410
knoflook commented 2022-04-12 11:44:23 +00:00
Author
Owner
Copy Link
Copy Source

saneyaml seems to do the job much better, merging this

saneyaml seems to do the job much better, merging this
knoflook merged commit 19ab610dfc into master 2022-04-12 11:44:35 +00:00
r commented 2022-04-13 09:44:34 +00:00
Member
Copy Link
Copy Source

closes #6

This PR broke some things:

  • Post content is now None (at least on the cards)
  • In the actual post HTML, foreign images are no longer replaced with local ones
  • Some post titles appear as a python dictionary.

Just to know, why did you end up escaping more characters in the frontmatter than the double quote? Did you encounter other issues?

AFAIK " is the only character that needs escaping from Hugo frontmatter formatted as YAML, because when the frontmatter is enclosed using double quotes instead of single ones, it doesn't interpret any other characters as syntax anymore.

> closes #6 This PR broke some things: * Post content is now None (at least on the cards) * In the actual post HTML, foreign images are no longer replaced with local ones * Some post titles appear as a python dictionary. Just to know, why did you end up escaping more characters in the frontmatter than the double quote? Did you encounter other issues? AFAIK `"` is the only character that needs escaping from Hugo frontmatter formatted as YAML, because when the frontmatter is enclosed using double quotes instead of single ones, it doesn't interpret any other characters as syntax anymore.
decentral1se commented 2022-04-13 10:49:20 +00:00
Owner
Copy Link
Copy Source

Reverted for now since we're doing the majelis.

58afd189a7

f6a1a684c0

7d3863641d

Reverted for now since we're doing the majelis. https://git.autonomic.zone/ruangrupa/lumbunglib/commit/58afd189a74ae6b77fb779fbcc8abde6e3448b6b https://git.autonomic.zone/ruangrupa/lumbunglib/commit/f6a1a684c0f974c5f9889a98a6d595b16ba1a1d5 https://git.autonomic.zone/ruangrupa/lumbunglib/commit/7d3863641dcb82859f9e99a43d96d41feee24b29
r commented 2022-04-13 13:02:37 +00:00
Member
Copy Link
Copy Source
  • In the actual post HTML, foreign images are no longer replaced with local ones

This seems an unrelated issue..

> * In the actual post HTML, foreign images are no longer replaced with local ones This seems an unrelated issue..
knoflook commented 2022-04-19 10:37:19 +00:00
Author
Owner
Copy Link
Copy Source

Just to know, why did you end up escaping more characters in the frontmatter than the double quote? Did you encounter other issues?

as specified in ruangrupa/lumbunglib#6 (comment), square brackets and other things that are part of the yaml syntax also need to be escaped. I recall having issues with other characters too, but I don't remember which ones these were specifically. I'll do some testing locally and re-open the PR if needed.

> Just to know, why did you end up escaping more characters in the frontmatter than the double quote? Did you encounter other issues? as specified in https://git.autonomic.zone/ruangrupa/lumbunglib/issues/6#issuecomment-9577, square brackets and other things that are part of the yaml syntax also need to be escaped. I recall having issues with other characters too, but I don't remember which ones these were specifically. I'll do some testing locally and re-open the PR if needed.
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
aadil (Aadil Ayub) autono-bot (Autono-bot) autonomic chocobozzz christoph decentral1se (decentral1se) Esthetech knoflook r (rra) simoon
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ruangrupa/konfluks#28