v0.96.1: songs are named in Unicode NFC in the music folder, since Syncthing renames anything else under the library (a Bengali YouTube title lost its file that way); a song already renamed so is followed

This commit is contained in:
2026-11-17 22:21:29 -08:00
parent 9f2f9222dd
commit b78b6c5275
6 changed files with 106 additions and 4 deletions
+61
View File
@@ -437,3 +437,64 @@ def test_the_shown_playlists_cover_shows_while_nothing_plays(window, qapp,
window._show_library() # no playlist shown
assert not art.showing_playlist_art() and not art.has_art()
# --------------------------------------------------------------------------
# H. names Syncthing would rename: written in NFC, and followed if renamed
import os # noqa: E402
import shutil # noqa: E402
import unicodedata # noqa: E402
from lintunes.importers import file_importer # noqa: E402
from lintunes.library_manager import LibraryManager # noqa: E402
from lintunes.models import Library # noqa: E402
# "বাড়ি" as YouTube spells it: U+09DC, which NFC writes as U+09A1 U+09BC.
RAW = "বাড়ি"
NFC = unicodedata.normalize("NFC", RAW)
def test_the_raw_name_is_not_nfc():
assert RAW != NFC
def _manager(tmp_path):
media = tmp_path / "media"
(media / "Music").mkdir(parents=True)
return LibraryManager(Library(music_folder=str(media)), tmp_path / "data")
def test_an_import_is_named_in_nfc(tmp_path, mp3_file, qapp):
src = tmp_path / "dl" / f"{RAW} [abc].mp3"
src.parent.mkdir()
shutil.copy(mp3_file, src)
manager = _manager(tmp_path)
track = file_importer.import_file(src, manager.organize_root(), manager)
assert os.path.basename(track.location) == f"{NFC} [abc].mp3"
assert os.path.exists(track.location)
def test_a_file_syncthing_renamed_is_followed(tmp_path, mp3_file, qapp):
manager = _manager(tmp_path)
folder = manager.organize_root() / "Unknown Artist" / "Unknown Album"
folder.mkdir(parents=True)
raw = folder / f"{RAW}.mp3"
shutil.copy(mp3_file, raw)
track = Track(track_id=1, name=RAW, location=str(raw))
manager.add_track(track)
os.rename(raw, folder / f"{NFC}.mp3") # what Syncthing does
manager.edit_track_fields(1, {"artist": "Someone", "album": "Bhandari"})
assert os.path.exists(track.location)
assert track.location.endswith(f"Someone/Bhandari/{NFC}.mp3")
from lintunes import tagging
assert tagging.read_tags(track.location)["artist"] == "Someone"
def test_a_missing_file_with_no_nfc_twin_stays_missing(tmp_path, qapp):
manager = _manager(tmp_path)
track = Track(track_id=1, name="x", location=str(tmp_path / "gone.mp3"))
manager.add_track(track)
assert not manager.repair_location(track)
assert track.location == str(tmp_path / "gone.mp3")