3wordchant/capsul-flask
1
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

Add custom themes, THEME setting, basic "yolocolo" theme #7

Merged
3wordchant merged 11 commits from yc-templates into master 2021-07-21 23:15:40 +00:00
Conversation 5 Commits 11 Files Changed 11 +387 -1
3wordchant commented 2021-07-21 20:31:19 +00:00
Owner
Copy Link

Specify THEME=yourtheme, add some HTML files in capsulflask/theme/yourtheme 👌

We probably want to reduce copypasta in the current yolocolo theme by using template inheritance, at some point.

Specify `THEME=yourtheme`, add some HTML files in `capsulflask/theme/yourtheme` 👌 We probably want to reduce copypasta in the current `yolocolo` theme by using template inheritance, at some point.
3wordchant added 8 commits 2021-07-21 20:31:20 +00:00 
..configurable using the THEME env var.

Defaults to normal Capsul theme.
decentral1se approved these changes 2021-07-21 20:47:27 +00:00
decentral1se left a comment
Collaborator
Copy Link

y e s

y e s
3wordchant added 1 commit 2021-07-21 20:49:07 +00:00
forest commented 2021-07-21 21:26:10 +00:00
Collaborator
Copy Link

The capsulflask/static/icon.png and favicon should probably not be modified, the custom theme HTML can simply specify a different image for those right?

The capsulflask/static/icon.png and favicon should probably not be modified, the custom theme HTML can simply specify a different image for those right?
forest reviewed 2021-07-21 21:27:19 +00:00
capsulflask/__init__.py
@ -157,0 +164,4 @@
'capsulflask/templates']),
])
app.jinja_loader = my_loader
forest commented 2021-07-21 21:27:19 +00:00
Collaborator
Copy Link

This is cool, I had no idea one could do this.

This is cool, I had no idea one could do this.
👀 1
3wordchant commented 2021-07-21 21:33:17 +00:00
Author
Owner
Copy Link

I learned it today on the internet 😁

I learned it today on the internet 😁
forest commented 2021-07-21 21:28:48 +00:00
Collaborator
Copy Link

How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately?

How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately?
3wordchant added 1 commit 2021-07-21 21:32:41 +00:00
3wordchant commented 2021-07-21 21:34:59 +00:00
Author
Owner
Copy Link

The capsulflask/static/icon.png and favicon should probably not be modified, the custom theme HTML can simply specify a different image for those right?

Yep, reverted, that was a mistake! 😳

How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately?

No preference, you got any leanings?

> The capsulflask/static/icon.png and favicon should probably not be modified, the custom theme HTML can simply specify a different image for those right? Yep, reverted, that was a mistake! 😳 > How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately? No preference, you got any leanings?
forest commented 2021-07-21 22:30:59 +00:00
Collaborator
Copy Link

How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately?

No preference, you got any leanings?

Just keep it in the main repo, it will make your life easier and provide an example of how to use the theme feature. J3s ok with this too.

> > How do you wanna do this moving forward, you keep the yolocolo theme in the main repo? Or do you wanna make a separate repo for the yolocolo theme and then update/deploy it separately? > > No preference, you got any leanings? Just keep it in the main repo, it will make your life easier and provide an example of how to use the theme feature. J3s ok with this too.
forest commented 2021-07-21 22:35:39 +00:00
Collaborator
Copy Link

LGTM

LGTM
3wordchant added 1 commit 2021-07-21 23:05:02 +00:00
3wordchant merged commit 5bb76173dd into master 2021-07-21 23:15:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
decentral1se
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 3wordchant/capsul-flask#7
No description provided.
Delete Branch "yc-templates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?