autonomic-cooperative/hometown
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove character counter from edit profile (#9100)

Browse Source 
* Remove display name and bio counter hint, simply limit input

* Remove now redundant translations

* Fix code style issue
This commit is contained in:
Eugen Rochko
2018-10-26 01:55:24 +02:00
committed by GitHub
parent 768b0f132d
commit 161aeadbb4
47 changed files with 5 additions and 268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/javascript/packs/public.js
View File

@ -21,7 +21,6 @@ window.addEventListener('message', e => {
});
function main() {
const { length } = require('stringz');
const IntlMessageFormat = require('intl-messageformat').default;
const { timeAgoString } = require('../mastodon/components/relative_timestamp');
const { delegate } = require('rails-ujs');
@ -133,26 +132,13 @@ function main() {
});
delegate(document, '#account_display_name', 'input', ({ target }) => {
const nameCounter = document.querySelector('.name-counter');
const name = document.querySelector('.card .display-name strong');
if (nameCounter) {
nameCounter.textContent = 30 - length(target.value);
}
const name = document.querySelector('.card .display-name strong');
if (name) {
name.innerHTML = emojify(target.value);
}
});
delegate(document, '#account_note', 'input', ({ target }) => {
const noteCounter = document.querySelector('.note-counter');
if (noteCounter) {
noteCounter.textContent = 160 - length(target.value);
}
});
delegate(document, '#account_avatar', 'change', ({ target }) => {
const avatar = document.querySelector('.card .avatar img');
const [file] = target.files || [];

8
app/views/settings/profiles/show.html.haml
View File

@ -6,8 +6,8 @@
.fields-row
.fields-row__column.fields-group.fields-row__column-6
= f.input :display_name, wrapper: :with_label, hint: t('simple_form.hints.defaults.display_name', count: 30 - @account.display_name.size).html_safe
= f.input :note, wrapper: :with_label, hint: t('simple_form.hints.defaults.note', count: 160 - @account.note.size).html_safe
= f.input :display_name, wrapper: :with_label, input_html: { maxlength: 30 }, hint: false
= f.input :note, wrapper: :with_label, input_html: { maxlength: 160 }, hint: false
.fields-row
.fields-row__column.fields-row__column-6
@ -36,8 +36,8 @@
= f.simple_fields_for :fields do |fields_f|
.row
= fields_f.input :name, placeholder: t('simple_form.labels.account.fields.name')
= fields_f.input :value, placeholder: t('simple_form.labels.account.fields.value')
= fields_f.input :name, placeholder: t('simple_form.labels.account.fields.name'), input_html: { maxlength: 255 }
= fields_f.input :value, placeholder: t('simple_form.labels.account.fields.value'), input_html: { maxlength: 255 }
.fields-row__column.fields-group.fields-row__column-6
%h6= t('verification.verification')