Add media dimensions (#2448)
* Fixes #1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb
This commit is contained in:
committed by
Eugen Rochko
parent
8fe36654ef
commit
193dddb433
@ -11,6 +11,13 @@ RSpec.describe MediaAttachment, type: :model do
|
||||
it 'converts original file to mp4' do
|
||||
expect(media.file_content_type).to eq 'video/mp4'
|
||||
end
|
||||
|
||||
it 'sets meta' do
|
||||
expect(media.file.meta["original"]["width"]).to eq 128
|
||||
expect(media.file.meta["original"]["height"]).to eq 128
|
||||
expect(media.file.meta["original"]["aspect"]).to eq 1.0
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe 'non-animated gif non-conversion' do
|
||||
@ -23,5 +30,24 @@ RSpec.describe MediaAttachment, type: :model do
|
||||
it 'leaves original file as-is' do
|
||||
expect(media.file_content_type).to eq 'image/gif'
|
||||
end
|
||||
|
||||
it 'sets meta' do
|
||||
expect(media.file.meta["original"]["width"]).to eq 600
|
||||
expect(media.file.meta["original"]["height"]).to eq 400
|
||||
expect(media.file.meta["original"]["aspect"]).to eq 1.5
|
||||
end
|
||||
end
|
||||
|
||||
describe 'jpeg' do
|
||||
let(:media) { MediaAttachment.create(account: Fabricate(:account), file: attachment_fixture('attachment.jpg')) }
|
||||
|
||||
it 'sets meta for different style' do
|
||||
expect(media.file.meta["original"]["width"]).to eq 600
|
||||
expect(media.file.meta["original"]["height"]).to eq 400
|
||||
expect(media.file.meta["original"]["aspect"]).to eq 1.5
|
||||
expect(media.file.meta["small"]["width"]).to eq 400
|
||||
expect(media.file.meta["small"]["height"]).to eq 267
|
||||
expect(media.file.meta["small"]["aspect"]).to eq 400.0/267
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user