Replace best_in_place editor on admin settings page (#2789)

* Remove best_in_place * Replace best_in_place usage with rails helpers * Move admin/settings#index to #edit action * Remove click_to__edit from i18n
2017-05-04 12:12:44 -04:00
parent 91ddd345f2
commit 2bd132d458
28 changed files with 117 additions and 97 deletions
--- a/config/locales/de.yml
+++ b/config/locales/de.yml
@ -145,7 +145,6 @@ de:
      unresolved: Ungelöst
      view: Ansehen
    settings:
-      click_to_edit: Klicken zum Bearbeiten
      contact_information:
        email: Eine öffentliche E-Mail-Adresse angeben
        label: Kontaktinformationen
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@ -158,7 +158,6 @@ en:
      unresolved: Unresolved
      view: View
    settings:
-      click_to_edit: Click to edit
      contact_information:
        email: Enter a public e-mail address
        label: Contact information
--- a/config/locales/fa.yml
+++ b/config/locales/fa.yml
@ -156,7 +156,6 @@ fa:
      unresolved: حل‌نشده
      view: نمایش
    settings:
-      click_to_edit: برای ویرایش کلیک کنید
      contact_information:
        email: یک نشانی ایمیل عمومی وارد کنید
        label: اطلاعات تماس
@ -297,7 +296,7 @@ fa:
    visibilities:
      private: نمایش تنها به پیگیران
      public: عمومی
-      unlisted: عمومی، ولی در فهرست نوشته‌ها نمایش نده 
+      unlisted: عمومی، ولی در فهرست نوشته‌ها نمایش نده
  stream_entries:
    click_to_show: برای نمایش کلیک کنید
    reblogged: بازبوقیده
--- a/config/locales/fr.yml
+++ b/config/locales/fr.yml
@ -136,7 +136,6 @@ fr:
      unresolved: Non résolus
      view: Voir
    settings:
-      click_to_edit: Cliquez pour éditer
      contact_information:
        email: Entrez une adresse courriel publique
        label: Informations de contact
--- a/config/locales/he.yml
+++ b/config/locales/he.yml
@ -157,7 +157,6 @@ he:
      unresolved: לא פתור
      view: תצוגה
    settings:
-      click_to_edit: לחיצה כדי לערוך
      contact_information:
        email: 'נא להקליד כתובת דוא"ל פומבית'
        label: פרטי התקשרות
--- a/config/locales/id.yml
+++ b/config/locales/id.yml
@ -156,7 +156,6 @@ id:
      unresolved: Belum Terseleseikan
      view: Tampilan
    settings:
-      click_to_edit: Klik untuk mengubah
      contact_information:
        email: Masukkan alamat email
        label: Informasi kontak
--- a/config/locales/io.yml
+++ b/config/locales/io.yml
@ -144,7 +144,6 @@ io:
      unresolved: Unresolved
      view: View
    settings:
-      click_to_edit: Click to edit
      contact_information:
        email: Enter a public e-mail address
        label: Contact information
--- a/config/locales/ja.yml
+++ b/config/locales/ja.yml
@ -157,7 +157,6 @@ ja:
      unresolved: 未解決
      view: 表示
    settings:
-      click_to_edit: クリックして編集
      contact_information:
        email: 公開するメールアドレスを入力
        label: 連絡先情報
--- a/config/locales/nl.yml
+++ b/config/locales/nl.yml
@ -41,7 +41,6 @@ nl:
    unfollow: Ontvolgen
  admin:
    settings:
-      click_to_edit: Klik om te bewerken
      contact_information:
        email: Vul een openbaar gebruikt e-mailadres in
        label: Contactgegevens
--- a/config/locales/oc.yml
+++ b/config/locales/oc.yml
@ -146,7 +146,6 @@ oc:
      unresolved: Pas resolguts
      view: Veire
    settings:
-      click_to_edit: Clicatz per modificar
      contact_information:
        email: Picatz una adreça de corrièl
        label: Informacions de contacte
--- a/config/locales/pl.yml
+++ b/config/locales/pl.yml
@ -12,7 +12,7 @@ pl:
    domain_count_before: Serwer połączony z
    features:
      api: Otwarte API dla aplikacji i usług
-      blocks: Rozbudowane narzędzia blokowania i ukrywania 
+      blocks: Rozbudowane narzędzia blokowania i ukrywania
      characters: 500 znaków na wpis
      chronology: Chronologiczny porządek wyświetlania
      ethics: 'Etyczne założenia: nie śledzimy, bez reklam'
@ -158,7 +158,6 @@ pl:
      unresolved: Nierozwiązane
      view: Wyświetl
    settings:
-      click_to_edit: Naciśnij, aby edytować
      contact_information:
        email: Wprowadź publiczny adres e-mail
        label: Informacje kontaktowe
--- a/config/locales/pt-BR.yml
+++ b/config/locales/pt-BR.yml
@ -157,7 +157,6 @@ pt-BR:
      unresolved: Unresolved
      view: View
    settings:
-      click_to_edit: Clique para editar
      contact_information:
        email: Entre um endereço de email público
        label: Informação de contato
--- a/config/locales/pt.yml
+++ b/config/locales/pt.yml
@ -152,7 +152,6 @@ pt:
      unresolved: Por resolver
      view: Ver
    settings:
-      click_to_edit: Clique para editar
      contact_information:
        email: Inserir um endereço de email para tornar público
        label: Informação de contacto
--- a/config/locales/ru.yml
+++ b/config/locales/ru.yml
@ -29,7 +29,7 @@ ru:
    terms: Условия
    user_count_after: пользователей
    user_count_before: Здесь живет
-    version: Версия    
+    version: Версия
  accounts:
    follow: Подписаться
    followers: Подписчики
@ -139,7 +139,6 @@ ru:
      unresolved: Неразрешенные
      view: Просмотреть
    settings:
-      click_to_edit: Нажмите для изменения
      contact_information:
        email: Введите публичный e-mail
        label: Контактная информация
--- a/config/locales/th.yml
+++ b/config/locales/th.yml
@ -35,7 +35,7 @@ th:
    followers: ผู้ติดตาม
    following: กำลังติดตาม
    nothing_here: ไม่พบสิ่งใดที่นี่!
-    people_followed_by: ถูกติดตามโดย %{name} 
+    people_followed_by: ถูกติดตามโดย %{name}
    people_who_follow: คนที่ติดตาม %{name}
    posts: โพสต์
    remote_follow: Remote follow
@ -157,7 +157,6 @@ th:
      unresolved: Unresolved
      view: วิว
    settings:
-      click_to_edit: คลิ๊กเพื่อแก้ไข
      contact_information:
        email: กรอกที่อยู่อีเมล์สาธารณะ
        label: ข้อมูลที่ติดต่อ
--- a/config/locales/zh-CN.yml
+++ b/config/locales/zh-CN.yml
@ -154,7 +154,6 @@ zh-CN:
      unresolved: 未处理
      view: 查看
    settings:
-      click_to_edit: 点击编辑
      contact_information:
        email: 输入一个公开的电邮地址
        label: 联系数据
--- a/config/locales/zh-HK.yml
+++ b/config/locales/zh-HK.yml
@ -141,7 +141,6 @@ zh-HK:
      unresolved: 未處理
      view: 檢視
    settings:
-      click_to_edit: 點擊編輯
      contact_information:
        email: 輸入一個公開的電郵地址
        label: 聯絡資料
--- a/config/locales/zh-TW.yml
+++ b/config/locales/zh-TW.yml
@ -118,7 +118,6 @@ zh-TW:
      unresolved: 未解決
      view: 檢視
    settings:
-      click_to_edit: 點選以編輯
      contact_information:
        email: 請輸入輸入一個公開電子信箱
        label: 聯絡資訊
--- a/config/navigation.rb
+++ b/config/navigation.rb
@ -23,7 +23,7 @@ SimpleNavigation::Configuration.run do |navigation|
      admin.item :domain_blocks, safe_join([fa_icon('lock fw'), t('admin.domain_blocks.title')]), admin_domain_blocks_url, highlights_on: %r{/admin/domain_blocks}
      admin.item :sidekiq, safe_join([fa_icon('diamond fw'), 'Sidekiq']), sidekiq_url, link_html: { target: 'sidekiq' }
      admin.item :pghero, safe_join([fa_icon('database fw'), 'PgHero']), pghero_url, link_html: { target: 'pghero' }
-      admin.item :settings, safe_join([fa_icon('cogs fw'), t('admin.settings.title')]), admin_settings_url
+      admin.item :settings, safe_join([fa_icon('cogs fw'), t('admin.settings.title')]), edit_admin_settings_url
    end

    primary.item :logout, safe_join([fa_icon('sign-out fw'), t('auth.logout')]), destroy_user_session_url, link_html: { 'data-method' => 'delete' }
--- a/config/routes.rb
+++ b/config/routes.rb
@ -76,7 +76,7 @@ Rails.application.routes.draw do
  namespace :admin do
    resources :pubsubhubbub, only: [:index]
    resources :domain_blocks, only: [:index, :new, :create, :show, :destroy]
-    resources :settings, only: [:index, :update]
+    resource :settings, only: [:edit, :update]
    resources :instances, only: [:index]

    resources :reports, only: [:index, :show, :update] do