Do not allow adding votes to expired polls (#10214)

* Do not allow adding votes to expired polls * Only validate expires_at on create
2019-03-08 00:54:50 +01:00
parent 054bbb3da2
commit 3aaac4f134
4 changed files with 26 additions and 1 deletions
--- a/app/models/poll.rb
+++ b/app/models/poll.rb
@ -28,7 +28,7 @@ class Poll < ApplicationRecord

  validates :options, presence: true
  validates :expires_at, presence: true, if: :local?
-  validates_with PollValidator, if: :local?
+  validates_with PollValidator, on: :create, if: :local?

  scope :attached, -> { where.not(status_id: nil) }
  scope :unattached, -> { where(status_id: nil) }