Fix expired announcements being re-published (#12964)

2020-01-26 22:43:18 +01:00
parent 2f8c3c17ee
commit 401f32f9ee
5 changed files with 16 additions and 9 deletions
--- a/app/workers/publish_scheduled_announcement_worker.rb
+++ b/app/workers/publish_scheduled_announcement_worker.rb
@ -6,7 +6,8 @@ class PublishScheduledAnnouncementWorker

  def perform(announcement_id)
    announcement = Announcement.find(announcement_id)
-    announcement.update(published: true)
+
+    announcement.update(published: true, published_at: Time.now.utc, scheduled_at: nil) unless announcement.published?

    payload = InlineRenderer.render(announcement, nil, :announcement)
    payload = Oj.dump(event: :announcement, payload: payload)