Close http connection in perform method of Request class (#6889)
HTTP connections must be explicitly closed in many cases, and letting perform method close connections makes its callers less redundant and prevent them from forgetting to close connections.
This commit is contained in:
committed by
Eugen Rochko
parent
4e71b104e6
commit
54b273bf99
@ -21,8 +21,8 @@ class Pubsubhubbub::ConfirmationWorker
|
||||
def process_confirmation
|
||||
prepare_subscription
|
||||
|
||||
confirm_callback
|
||||
logger.debug "Confirming PuSH subscription for #{subscription.callback_url} with challenge #{challenge}: #{callback_response_body}"
|
||||
callback_get_with_params
|
||||
logger.debug "Confirming PuSH subscription for #{subscription.callback_url} with challenge #{challenge}: #{@callback_response_body}"
|
||||
|
||||
update_subscription
|
||||
end
|
||||
@ -44,7 +44,7 @@ class Pubsubhubbub::ConfirmationWorker
|
||||
end
|
||||
|
||||
def response_matches_challenge?
|
||||
callback_response_body == challenge
|
||||
@callback_response_body == challenge
|
||||
end
|
||||
|
||||
def subscribing?
|
||||
@ -55,16 +55,10 @@ class Pubsubhubbub::ConfirmationWorker
|
||||
mode == 'unsubscribe'
|
||||
end
|
||||
|
||||
def confirm_callback
|
||||
@_confirm_callback ||= callback_get_with_params
|
||||
end
|
||||
|
||||
def callback_get_with_params
|
||||
Request.new(:get, subscription.callback_url, params: callback_params).perform
|
||||
end
|
||||
|
||||
def callback_response_body
|
||||
confirm_callback.body.to_s
|
||||
Request.new(:get, subscription.callback_url, params: callback_params).perform do |response|
|
||||
@callback_response_body = response.body.to_s
|
||||
end
|
||||
end
|
||||
|
||||
def callback_params
|
||||
|
Reference in New Issue
Block a user