Add optimistic lock to avoid race conditions when handling votes (#10196)

* Add optimistic lock to avoid race conditions when handling votes * Force-reload polls when getting `ActiveRecord::StaleObjectError`
2019-03-06 19:53:57 +01:00
parent b3668a79ec
commit 96f905f409
4 changed files with 12 additions and 1 deletions
--- a/app/models/poll_vote.rb
+++ b/app/models/poll_vote.rb
@ -32,5 +32,8 @@ class PollVote < ApplicationRecord
  def increment_counter_cache
    poll.cached_tallies[choice] = (poll.cached_tallies[choice] || 0) + 1
    poll.save
+  rescue ActiveRecord::StaleObjectError
+    poll.reload
+    retry
  end
 end